patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Luca Boccassi <bluca@debian.org>
Cc: stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"christian.ehrhardt@canonical.com"
	<christian.ehrhardt@canonical.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] build: mention -march in pkg-config description
Date: Mon, 28 Jan 2019 01:50:56 +0100	[thread overview]
Message-ID: <15834031.ur9EiTGk5p@xps> (raw)
In-Reply-To: <20190111095732.GA21328@bricha3-MOBL.ger.corp.intel.com>

> > > Applications need to at least match DPDK's -march option to build
> > > successfully due to some static inline functions in the public headers.
> > >
> > > This might cause problems, especially in distributions, so add a note
> > > in the pkg-config description.
> > >
> > > Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > ---
> > > At the moment there are no adversely affected applications in Debian and
> > > Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder
> > > are stand-alone DPDK-specific binaries), but we thought that having an
> > > explicit notice would be good.
> > >
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
> > >  libraries: dpdk_libraries,
> > >  libraries_private: dpdk_drivers + dpdk_static_libraries +
> > >  ['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
> > > -description: 'The Data Plane Development Kit (DPDK)',
> > > +description: '''The Data Plane Development Kit (DPDK).
> > > +Note that CFLAGS might contain an -march flag higher than typical baseline.
> > > +This is required for a number of static inline functions in the public
> > From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance.
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > 
> No objection from me for more documentation.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

      reply	other threads:[~2019-01-28  0:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 17:28 [dpdk-stable] " Luca Boccassi
2019-01-11  3:58 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
2019-01-11  9:57   ` Bruce Richardson
2019-01-28  0:50     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15834031.ur9EiTGk5p@xps \
    --to=thomas@monjalon.net \
    --cc=Gavin.Hu@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).