From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E21C5A04AE for ; Sun, 16 Aug 2020 14:07:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AEBB71C0BD; Sun, 16 Aug 2020 14:07:09 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id CB1CC1C0BD for ; Sun, 16 Aug 2020 14:07:06 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from michaelba@mellanox.com) with SMTP; 16 Aug 2020 15:07:06 +0300 Received: from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx [10.210.16.112]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 07GC75Bh008777; Sun, 16 Aug 2020 15:07:05 +0300 Received: from pegasus07.mtr.labs.mlnx (localhost [127.0.0.1]) by pegasus07.mtr.labs.mlnx (8.14.7/8.14.7) with ESMTP id 07GC75F2008093; Sun, 16 Aug 2020 12:07:05 GMT Received: (from michaelba@localhost) by pegasus07.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id 07GC75DY008092; Sun, 16 Aug 2020 12:07:05 GMT From: Michael Baum To: stable@dpdk.org Cc: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Michael Baum Date: Sun, 16 Aug 2020 12:06:54 +0000 Message-Id: <1597579615-8044-1-git-send-email-michaelba@mellanox.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-stable] [PATCH 19.11 1/2] net/mlx5: fix hairpin Tx queue creation error flow X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" [ upstream commit 7e6eba619d6129ec7dcb07d3d0a26785f1c43af6 ] The mlx5_txq_obj_hairpin_new function defines a pointer named tmpl and allocates memory for it using the rte_zmalloc_socket function. Later, this function allocates memory to a variable inside tmpl using the mlx5_devx_cmd_create_sq function. In both cases, if the allocation fails, the code jumps to the error label and frees allocated resources. However, in the first jump there are still no resources to free and the jump only for the line return NULL is unnecessary. Even worse, when it jumps to error label with invalid tmpl it actually does dereference to a null pointer. In contrast, the second jump needs to free the tmpl variable but the function instead of freeing, tries to free the variable that it just failed to allocate, and another variable that has never been allocated. In addition, for another error, the function returns NULL without freeing the tmpl variable before, causing a memory leak. Delete the error label and replace each jump with local return NULL and free tmpl variable if needed. Fixes: ae18a1ae9692 ("net/mlx5: support Tx hairpin queues") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_txq.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index 0b092c4..f688027 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -514,7 +514,6 @@ container_of(txq_data, struct mlx5_txq_ctrl, txq); struct mlx5_devx_create_sq_attr attr = { 0 }; struct mlx5_txq_obj *tmpl = NULL; - int ret = 0; uint32_t max_wq_data; assert(txq_data); @@ -526,7 +525,7 @@ "port %u Tx queue %u cannot allocate memory resources", dev->data->port_id, txq_data->idx); rte_errno = ENOMEM; - goto error; + return NULL; } tmpl->type = MLX5_TXQ_OBJ_TYPE_DEVX_HAIRPIN; tmpl->txq_ctrl = txq_ctrl; @@ -547,22 +546,15 @@ DRV_LOG(ERR, "port %u tx hairpin queue %u can't create sq object", dev->data->port_id, idx); + rte_free(tmpl); rte_errno = errno; - goto error; + return NULL; } DRV_LOG(DEBUG, "port %u sxq %u updated with %p", dev->data->port_id, idx, (void *)&tmpl); rte_atomic32_inc(&tmpl->refcnt); LIST_INSERT_HEAD(&priv->txqsobj, tmpl, next); return tmpl; -error: - ret = rte_errno; /* Save rte_errno before cleanup. */ - if (tmpl->tis) - mlx5_devx_cmd_destroy(tmpl->tis); - if (tmpl->sq) - mlx5_devx_cmd_destroy(tmpl->sq); - rte_errno = ret; /* Restore rte_errno. */ - return NULL; } /** -- 1.8.3.1