From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, dev@dpdk.org, zhihong.wang@intel.com
Cc: lvyilong.lyl@alibaba-inc.com, yinan.wang@intel.com,
xnhp0320@icloud.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 2/3] vhost: fix vring addr handling during live migration
Date: Fri, 27 Sep 2019 09:54:39 +0200 [thread overview]
Message-ID: <15bba8a1-dc4d-667e-842d-87534d013df5@redhat.com> (raw)
In-Reply-To: <20190819113457.15569-3-tiwei.bie@intel.com>
On 8/19/19 1:34 PM, Tiwei Bie wrote:
> When live migration starts, QEMU will set ring addrs again for
> each virtqueue. In this case, we should try to translate ring
> addrs after we invalidating the ring, otherwise virtqueues can
> be enabled with the addrs untranslated. Besides, also leverage
> the access_ok flag in non-IOMMU case to prevent the data path
> accessing invalidated virtqueues.
>
> Fixes: 5a4933e56be4 ("vhost: postpone ring address translations at kick time only")
> Cc: stable@dpdk.org
>
> Reported-by: Yilong Lv <lvyilong.lyl@alibaba-inc.com>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> lib/librte_vhost/vhost.c | 3 +--
> lib/librte_vhost/vhost_user.c | 12 ++++++++++--
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2019-09-27 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190819113457.15569-1-tiwei.bie@intel.com>
2019-08-19 11:34 ` [dpdk-stable] [PATCH 1/3] vhost: do not realloc device and queues during running Tiwei Bie
2019-09-18 13:30 ` Maxime Coquelin
2019-08-19 11:34 ` [dpdk-stable] [PATCH 2/3] vhost: fix vring addr handling during live migration Tiwei Bie
2019-09-27 7:54 ` Maxime Coquelin [this message]
2019-08-19 11:34 ` [dpdk-stable] [PATCH 3/3] vhost: protect vring access done by application Tiwei Bie
2019-09-27 8:25 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15bba8a1-dc4d-667e-842d-87534d013df5@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=lvyilong.lyl@alibaba-inc.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=xnhp0320@icloud.com \
--cc=yinan.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).