From: Phil Yang <phil.yang@arm.com>
To: dev@dpdk.org, david.marchand@redhat.com
Cc: juraj.linkes@pantheon.tech, Ruifeng.Wang@arm.com, nd@arm.com,
stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Luca Boccassi <bluca@debian.org>
Subject: [dpdk-stable] [PATCH v2 1/2] devtools: fix ninja install breakage under relative path
Date: Wed, 23 Sep 2020 17:40:11 +0800 [thread overview]
Message-ID: <1600854012-10226-1-git-send-email-phil.yang@arm.com> (raw)
In-Reply-To: <1594277585-15281-1-git-send-email-phil.yang@arm.com>
As the DESTDIR variable use as ninja's destination directory when invoking
ninja install. If the DESTDIR is not an absolute path, ninja complains.
Fixes: 777014e56d07 ("devtools: add ABI checks")
Cc: stable@dpdk.org
Signed-off-by: Phil Yang <phil.yang@arm.com>
---
v2:
Use readlink to ensure consistent coding style. (Juraj)
v1:
Initial version.
devtools/test-meson-builds.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index a87de63..5236b9c 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -143,7 +143,8 @@ build () # <directory> <target compiler | cross file> <meson options>
config $srcdir $builds_dir/$targetdir $cross --werror $*
compile $builds_dir/$targetdir
if [ -n "$DPDK_ABI_REF_VERSION" ]; then
- abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION
+ abirefdir=$(readlink -f \
+ ${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION)
if [ ! -d $abirefdir/$targetdir ]; then
# clone current sources
if [ ! -d $abirefdir/src ]; then
--
2.7.4
next parent reply other threads:[~2020-09-23 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1594277585-15281-1-git-send-email-phil.yang@arm.com>
2020-09-23 9:40 ` Phil Yang [this message]
2020-09-23 10:12 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600854012-10226-1-git-send-email-phil.yang@arm.com \
--to=phil.yang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).