From: Long Li <longli@linuxonhyperv.com> To: Gaetan Rivet <grive@u256.net> Cc: dev@dpdk.org, Long Li <longli@microsoft.com>, stable@dpdk.org Subject: [dpdk-stable] [PATCH] net/failsafe: check correct error code while handling sub-device add Date: Fri, 2 Oct 2020 17:01:48 -0700 Message-ID: <1601683308-18738-1-git-send-email-longli@linuxonhyperv.com> (raw) From: Long Li <longli@microsoft.com> When adding a sub-device, it's possible that the sub-device is configured successfully but later fails to start. This error should not be masked. The driver needs to check the error status to prevent endless loop of trying to start the sub-device. fixes (ae80146c5a1b net/failsafe: fix removed device handling) cc: stable@dpdk.org Signed-off-by: Long Li <longli@microsoft.com> --- drivers/net/failsafe/failsafe_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h index 651578a..c58c0de 100644 --- a/drivers/net/failsafe/failsafe_private.h +++ b/drivers/net/failsafe/failsafe_private.h @@ -497,7 +497,7 @@ int failsafe_eth_new_event_callback(uint16_t port_id, fs_err(struct sub_device *sdev, int err) { /* A device removal shouldn't be reported as an error. */ - if (sdev->remove == 1 || err == -EIO) + if (sdev->remove == 1 && err == -EIO) return rte_errno = 0; return err; } -- 1.8.3.1
next reply other threads:[~2020-10-03 0:02 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-03 0:01 Long Li [this message] 2020-10-05 9:42 ` Gaëtan Rivet 2020-10-09 16:20 ` [dpdk-stable] [dpdk-dev] " Gaëtan Rivet 2020-10-09 20:30 ` Long Li 2020-10-12 14:22 ` Gaëtan Rivet 2020-10-13 17:14 ` Long Li 2020-10-15 10:11 ` [dpdk-stable] " Gaëtan Rivet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1601683308-18738-1-git-send-email-longli@linuxonhyperv.com \ --to=longli@linuxonhyperv.com \ --cc=dev@dpdk.org \ --cc=grive@u256.net \ --cc=longli@microsoft.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git