From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D47EDA0521 for ; Thu, 5 Nov 2020 22:21:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81ED72C15; Thu, 5 Nov 2020 22:21:23 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3F5F72C01; Thu, 5 Nov 2020 22:21:20 +0100 (CET) IronPort-SDR: 6kClAkveDIgQrYzuLc9INykmERYNqXtfjJt7DPyeW+rby7EfbDIWCu8kqg3JVoh2BNPC1D9uB+ rqXoJXTdgksQ== X-IronPort-AV: E=McAfee;i="6000,8403,9796"; a="169574384" X-IronPort-AV: E=Sophos;i="5.77,454,1596524400"; d="scan'208";a="169574384" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 13:21:14 -0800 IronPort-SDR: mvl+hb+21kS47phXMRymrLNyL0XLToUk+sp3aAMe9cXNHsFmwoI4/1ef2tKN8rDf7s0TsS6eKE HlWx4Jf6a/4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,454,1596524400"; d="scan'208";a="354448982" Received: from txasoft-yocto.an.intel.com ([10.123.72.192]) by fmsmga004.fm.intel.com with ESMTP; 05 Nov 2020 13:21:14 -0800 From: Timothy McDaniel To: Gage Eads Cc: dev@dpdk.org, erik.g.carrillo@intel.com, harry.van.haaren@intel.com, jerinj@marvell.com, john.mcnamara@dpdk.org, stable@dpdk.org Date: Thu, 5 Nov 2020 15:22:52 -0600 Message-Id: <1604611374-2072-2-git-send-email-timothy.mcdaniel@intel.com> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1604611374-2072-1-git-send-email-timothy.mcdaniel@intel.com> References: <1604611374-2072-1-git-send-email-timothy.mcdaniel@intel.com> Subject: [dpdk-stable] [PATCH 3/4] event/dlb2: fix dereference NULL pointer Coverity warning X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Add NULL check before using t->mbuf_pool. Fixes: 6f1b828 ("event/dlb2: add self-tests") Coverity issue: 363719 Cc: stable@dpdk.org Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2_selftest.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/event/dlb2/dlb2_selftest.c b/drivers/event/dlb2/dlb2_selftest.c index e300067..f433654 100644 --- a/drivers/event/dlb2/dlb2_selftest.c +++ b/drivers/event/dlb2/dlb2_selftest.c @@ -212,7 +212,12 @@ test_stop_flush(struct test *t) /* test to check we can properly flush events */ goto err; } - count = rte_mempool_avail_count(t->mbuf_pool); + if (t->mbuf_pool) + count = rte_mempool_avail_count(t->mbuf_pool); + else { + printf("%d: mbuf_pool is NULL\n", __LINE__); + goto err; + } if (rte_event_port_attr_get(evdev, 0, -- 2.6.4