From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 04909A05D3
for <public@inbox.dpdk.org>; Mon, 22 Apr 2019 19:52:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id E8EBD1B452;
Mon, 22 Apr 2019 19:52:16 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6B4FC1B452;
Mon, 22 Apr 2019 19:52:15 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id C8C4022008;
Mon, 22 Apr 2019 13:52:14 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Mon, 22 Apr 2019 13:52:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=Iwb7UDSm2swd+BT3LZBNV4X5wpLQR6VW//kaieRxrPc=; b=GGm5R+uxSHNM
6VYdOLGfA8gu7OAk8NGA25CMBcOm50FoDHcOQno1JWkOMqbNgKfHCnXH0rbLea++
Ugh/WkRxQqypmCTT1qV0OmBRvob3F58gvHilFq2WPgbHi+WRDdO5eVnlQDERCShj
if7B8gcPVLovzkbitCIAhLjLG9plR40=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=Iwb7UDSm2swd+BT3LZBNV4X5wpLQR6VW//kaieRxr
Pc=; b=pvpKjk5hJZkHXvUIkAqzXRynhltajn1E37niafMzKqNOhteT93KvemC1o
BZTDkJdqGtH8dfCUOzDZGSvNl9EyE2Q00WL3p3/4TyD0G8PdlQkGlzEd6azKm+rH
uGyLonbOvLn41PQDoGZB/Jgt6qlyjqN27kj9g3zYMjyFcx2atfKHhivPuQPKsAom
aWFj3s8c0FbzesucPONDoRTo+9D/ct3EIOIFwRJ4lEdJKKY0BZkS+J75YDR6ju4p
Gll/o0r8VxZHkn5JWAvPQWVCnwXythBq6EN2mHYg3i8XeODDAl0Es5oh+pFzwwij
bXQMy9iZvIeiR/axQZEi+t+YJl/kA==
X-ME-Sender: <xms:Tf-9XLLvg33gYduDC649oQL9Zbgw72qSd12nuzWD70OHHGVlrXNDIw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigdduudefucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
hppeekfedrudduhedrudehhedrudefkeenucfrrghrrghmpehmrghilhhfrhhomhepthhh
ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:Tf-9XBvMDO6mRomm07WsQQyWjVkS--C8tMkPQJ9iUZ6Ta9sWW2m2aQ>
<xmx:Tf-9XEoonV3vogaREFtw8tL0-5CjoRi9YaFPV6r0QS4wQRcX8S7kgw>
<xmx:Tf-9XJbBNud5IXS0jez4nayRhDYKT6yCJd8wQVVnHpnkLwGPZ6KKig>
<xmx:Tv-9XMrRF-fjB9E1gaEmSgxVbDPPCIVA7LH02EONEI5kzKXLTpePMg>
Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr
[83.115.155.138])
by mail.messagingengine.com (Postfix) with ESMTPA id AAED0E43A3;
Mon, 22 Apr 2019 13:52:11 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Xu, Rosen" <rosen.xu@intel.com>, "Pei, Andy" <andy.pei@intel.com>
Cc: stable@dpdk.org, "dev@dpdk.org" <dev@dpdk.org>, "Kovacevic,
Marko" <marko.kovacevic@intel.com>, "liq3ea@163.com" <liq3ea@163.com>
Date: Mon, 22 Apr 2019 19:52:08 +0200
Message-ID: <1609679.gfMthc3lC5@xps>
In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A6B85AA@SHSMSX104.ccr.corp.intel.com>
References: <1555483757-48188-1-git-send-email-andy.pei@intel.com>
<1555485388-50214-1-git-send-email-andy.pei@intel.com>
<0E78D399C70DA940A335608C6ED296D73A6B85AA@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte
fpga do pr
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
> > In rte_fpga_do_pr() function, if 'stat' returns error,
> > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been
> > opened.
> > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL
> > when 'stat' returns error
> >
> > Coverity issue: 279441
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Cc: rosen.xu@intel.com
> > Cc: marko.kovacevic@intel.com
> > Cc: liq3ea@163.com
> > Cc: andy.pei@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Andy Pei <andy.pei@intel.com>
>
> Acked-by: Rosen Xu <rosen.xu@intel.com>
Li Qiang <liq3ea@163.com> proposed the same patch.
Why he is not referenced here?
Which patch should I merge?