From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C79CBA00C2
for <public@inbox.dpdk.org>; Wed, 17 Mar 2021 09:23:36 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 518A7242BAE;
Wed, 17 Mar 2021 09:23:36 +0100 (CET)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by mails.dpdk.org (Postfix) with ESMTP id BF28C242B89;
Wed, 17 Mar 2021 09:23:33 +0100 (CET)
IronPort-SDR: 0PUxyVCbJtQLRaLZjs8Xk9XI0FCUoV87VQuh9ygclzSp/II8Ta9rRd8HHNdnFnYfJGTpnOhmnt
fd5YdXngggRw==
X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="189507886"
X-IronPort-AV: E=Sophos;i="5.81,255,1610438400"; d="scan'208";a="189507886"
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
17 Mar 2021 01:23:33 -0700
IronPort-SDR: ZGqPURwKJhz50o9uXiTEmoLTiVccjV+jxsm9iiu+MEVO4so74lrek98CzpPLZe8NftBoVcYZ45
E7G2AMkN6HQw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.81,255,1610438400"; d="scan'208";a="605610970"
Received: from unknown (HELO sh_lab5_1.sh.intel.com) ([10.238.175.190])
by fmsmga005.fm.intel.com with ESMTP; 17 Mar 2021 01:23:31 -0700
From: Wei Huang <wei.huang@intel.com>
To: dev@dpdk.org,
rosen.xu@intel.com,
qi.z.zhang@intel.com
Cc: stable@dpdk.org, tianfei.zhang@intel.com, Wei Huang <wei.huang@intel.com>
Date: Wed, 17 Mar 2021 04:23:36 -0400
Message-Id: <1615969417-17118-2-git-send-email-wei.huang@intel.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1615969417-17118-1-git-send-email-wei.huang@intel.com>
References: <1615969417-17118-1-git-send-email-wei.huang@intel.com>
Subject: [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable
as argument
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
In fme_spi_init(), passing tainted expression "fme->max10_dev"
to function "intel_max10_device_remove" has risk. Untainted
variable "max10" should be used.
Coverity issue: 367480
Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
Signed-off-by: Wei Huang <wei.huang@intel.com>
---
drivers/raw/ifpga/base/ifpga_fme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c
index 43c7b9c3dc..a63f90331f 100644
--- a/drivers/raw/ifpga/base/ifpga_fme.c
+++ b/drivers/raw/ifpga/base/ifpga_fme.c
@@ -1001,7 +1001,7 @@ static int fme_spi_init(struct ifpga_feature *feature)
return ret;
max10_fail:
- intel_max10_device_remove(fme->max10_dev);
+ intel_max10_device_remove(max10);
spi_fail:
altera_spi_release(spi_master);
return ret;
--
2.29.2