* [dpdk-stable] [dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before null check [not found] <8a980b235eeba49721dfef9d0f23be375e8958b0.1616741870.git.wangyunjian@huawei.com> @ 2021-03-27 2:44 ` wangyunjian 2021-03-28 11:39 ` Raslan Darawsheh 0 siblings, 1 reply; 2+ messages in thread From: wangyunjian @ 2021-03-27 2:44 UTC (permalink / raw) To: dev Cc: matan, shahafs, viacheslavo, jerry.lilijun, chenchanghu, Yunjian Wang, stable From: Yunjian Wang <wangyunjian@huawei.com> Coverity flags that 'ctx->tunnel' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 366201 Fixes: 868d2e342cf3 ("net/mlx5: fix tunnel offload hub multi-thread protection") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> --- v2: add cc: stable@dpdk.org --- drivers/net/mlx5/mlx5_flow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index d46fc333d1..bb8d09cdef 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -7899,10 +7899,11 @@ static void get_tunnel_miss(struct rte_eth_dev *dev, void *x) rte_spinlock_unlock(&thub->sl); ctx->tunnel = mlx5_flow_tunnel_allocate(dev, ctx->app_tunnel); - ctx->tunnel->refctn = 1; rte_spinlock_lock(&thub->sl); - if (ctx->tunnel) + if (ctx->tunnel) { + ctx->tunnel->refctn = 1; LIST_INSERT_HEAD(&thub->tunnels, ctx->tunnel, chain); + } } -- 2.23.0 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before null check 2021-03-27 2:44 ` [dpdk-stable] [dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before null check wangyunjian @ 2021-03-28 11:39 ` Raslan Darawsheh 0 siblings, 0 replies; 2+ messages in thread From: Raslan Darawsheh @ 2021-03-28 11:39 UTC (permalink / raw) To: wangyunjian, dev Cc: Matan Azrad, Shahaf Shuler, Slava Ovsiienko, jerry.lilijun, chenchanghu, stable Hi, > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of wangyunjian > Sent: Saturday, March 27, 2021 5:44 AM > To: dev@dpdk.org > Cc: Matan Azrad <matan@nvidia.com>; Shahaf Shuler > <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; > jerry.lilijun@huawei.com; chenchanghu@huawei.com; Yunjian Wang > <wangyunjian@huawei.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before null > check > > From: Yunjian Wang <wangyunjian@huawei.com> > > Coverity flags that 'ctx->tunnel' variable is used before > it's checked for NULL. This patch fixes this issue. > > Coverity issue: 366201 > Fixes: 868d2e342cf3 ("net/mlx5: fix tunnel offload hub multi-thread > protection") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> > --- > v2: > add cc: stable@dpdk.org > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-28 11:39 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <8a980b235eeba49721dfef9d0f23be375e8958b0.1616741870.git.wangyunjian@huawei.com> 2021-03-27 2:44 ` [dpdk-stable] [dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before null check wangyunjian 2021-03-28 11:39 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).