From: Huisong Li <lihuisong@huawei.com>
To: <lihuisong@huawei.com>, <humin29@huawei.com>
Cc: <stable@dpdk.org>, Lijun Ou <oulijun@huawei.com>
Subject: [dpdk-stable] [PATCH V2 3/7] app/testpmd: fix a segment fault when DCB test
Date: Tue, 20 Apr 2021 15:30:31 +0800 [thread overview]
Message-ID: <1618903835-17444-4-git-send-email-lihuisong@huawei.com> (raw)
In-Reply-To: <1618903835-17444-1-git-send-email-lihuisong@huawei.com>
After DCB mode is configured, if we decrease the number of RX and TX
queues, fwd_config_setup() will be called to setup the DCB forwarding
configuration. And forwarding streams are updated based on new queue
numbers in fwd_config_setup(), but the mapping between the TC and
queues obtained by rte_eth_dev_get_dcb_info() is still old queue
numbers (old queue numbers are greater than new queue numbers).
In this case, the segment fault happens. So rte_eth_dev_configure()
should be called again to update the mapping between the TC and
queues before rte_eth_dev_get_dcb_info().
Like:
set nbcore 4
port stop all
port config 0 dcb vt off 4 pfc on
port start all
port stop all
port config all rxq 8
port config all txq 8
Fixes: 900550de04a7 ("app/testpmd: add dcb support")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
app/test-pmd/config.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 03ee40c..18b197b 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2996,7 +2996,33 @@ dcb_fwd_config_setup(void)
uint16_t nb_rx_queue, nb_tx_queue;
uint16_t i, j, k, sm_id = 0;
uint16_t total_tc_num;
+ struct rte_port *port;
uint8_t tc = 0;
+ portid_t pid;
+ int ret;
+
+ /*
+ * The fwd_config_setup() is called when the port is RTE_PORT_STARTED
+ * RTE_PORT_STOPPED. When a port is RTE_PORT_STARTED, dev_configure
+ * cannot be called.
+ *
+ * re-configure the device after changing queue numbers of stopped
+ * ports, so that the updated mapping between tc and queue can be
+ * obtained.
+ */
+ for (pid = 0; pid < nb_fwd_ports; pid++) {
+ if (port_is_started(pid) == 1)
+ continue;
+
+ port = &ports[pid];
+ ret = rte_eth_dev_configure(pid, nb_rxq, nb_txq,
+ &port->dev_conf);
+ if (ret < 0) {
+ printf("Failed to re-configure port %d, ret = %d.\n",
+ pid, ret);
+ return;
+ }
+ }
cur_fwd_config.nb_fwd_lcores = (lcoreid_t) nb_fwd_lcores;
cur_fwd_config.nb_fwd_ports = nb_fwd_ports;
--
2.7.4
next prev parent reply other threads:[~2021-04-20 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1618903835-17444-1-git-send-email-lihuisong@huawei.com>
2021-04-20 7:30 ` [dpdk-stable] [PATCH V2 1/7] app/testpmd: fix forward lcores number " Huisong Li
2021-04-20 7:30 ` [dpdk-stable] [PATCH V2 2/7] app/testpmd: fix DCB forwarding configuration Huisong Li
2021-04-20 7:30 ` Huisong Li [this message]
[not found] <1618901671-64742-1-git-send-email-lihuisong@huawei.com>
2021-04-20 6:54 ` [dpdk-stable] [PATCH V2 3/7] app/testpmd: fix a segment fault when DCB test Huisong Li
[not found] <1618886007-19567-1-git-send-email-lihuisong@huawei.com>
2021-04-20 2:33 ` [dpdk-stable] [PATCH V2 3/7] app/testpmd: fix a segment fault when dcb test Huisong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1618903835-17444-4-git-send-email-lihuisong@huawei.com \
--to=lihuisong@huawei.com \
--cc=humin29@huawei.com \
--cc=oulijun@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).