From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A5F111B494 for ; Thu, 20 Dec 2018 09:34:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4A09521D09; Thu, 20 Dec 2018 03:34:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 03:34:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=23ysfTDmhuvIxbOWwlAyh76yXVCV82gLEw0hegN2MbQ=; b=RQ0VhosvWTg5 sY9EWDUyPpKFPWAe7p/bMI4h/ecK7VVICGMMBbcmbaUb7rDYBXNfbfoLwrpe7B4V 0uTQD2leR9gR43NRShSGY62vR+9OIUMnnC9T/j3g4qnVLMqm3Fgf34ot6Pa541V9 h0fvmAJwzxHTHlM8rvYYKymRnysL/B8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=23ysfTDmhuvIxbOWwlAyh76yXVCV82gLEw0hegN2M bQ=; b=hpEG2jIvoY+1WouUwXXp735NZelsGnu27fKqQtYzB1SrSXgWXMGaBrKLm iT+MJGAwTMNlffcFxmWLA/uzxmlkIbam5l037QOqdlKicTDle2qIvXXH8JTsN1A+ 45yrxEB1YbSbAbdRxBMrhIB0elPn/nKhNm7UHTdCg/Tp28MOJekr2lYEonNQTjyy OV+dcZO96arPHMAcS1TfLgD95liGNgveSSGUJrjOd/l80hRFIK2LyFGKxX5Pvs1a AtXBRpD5LvlB//Ea+isbdGP15DJvrmib9A6WuJz+TbDMOjYDwf+1DvP2ppZP2izi ILL9GmqWbYXYHH8vkksw662182l+Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejvddguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkf gjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhn uceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuffhomhgrihhnpeguphgukh drohhrghdpohhuthhlohhokhdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeeg necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg htnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 100A8E4445; Thu, 20 Dec 2018 03:34:56 -0500 (EST) From: Thomas Monjalon To: Yongseok Koh Cc: Christian Ehrhardt , Adrien Mazarguil , David Wilder , Chao Zhu , dpdk stable Date: Thu, 20 Dec 2018 09:34:55 +0100 Message-ID: <1619027.JQlRWZmIXx@xps> In-Reply-To: References: <20181129231202.30436-1-yskoh@mellanox.com> <20181129231202.30436-103-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] patch 'net/mlx5: fix build on PPC64' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 08:35:00 -0000 mlx5 is not using bool in 17.11, so this patch is not required. 20/12/2018 01:20, Yongseok Koh: > Hi, > > This patch is being removed from stable/17.11 as it was mistakenly merged. > Patches having 'fix' keyword in the title were merged even though those don't > have "Cc: stable@dpdk.org" tag in the commit message. > > If you think this patch is still needed for stable/17.11, please let me know. > Then I'll take it back. > > > Thanks, > Yongseok > > > > On Nov 29, 2018, at 3:11 PM, Yongseok Koh wrote: > > > > Hi, > > > > FYI, your patch has been queued to LTS release 17.11.5 > > > > Note it hasn't been pushed to https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable&data=02%7C01%7Cyskoh%40mellanox.com%7C40c82295f497460bc8ab08d656508faf%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636791301339809185&sdata=LWhqqLssFQpwxlf1yKXdT2cGROcQv8w73TdAwoESdI8%3D&reserved=0 yet. > > It will be pushed if I get no objections before 12/01/18. So please > > shout if anyone has objections. > > > > Also note that after the patch there's a diff of the upstream commit vs the patch applied > > to the branch. If the code is different (ie: not only metadata diffs), due for example to > > a change in context or macro names, please double check it. > > > > Thanks. > > > > Yongseok > > > > --- > > From a8cbfdf37a4d6b207bed3e1825956c8bb9f21499 Mon Sep 17 00:00:00 2001 > > From: Thomas Monjalon > > Date: Wed, 7 Nov 2018 17:00:28 +0100 > > Subject: [PATCH] net/mlx5: fix build on PPC64 > > > > [ upstream commit 725f5dd0bfb50192a2d2341d4cc69084c2c4e03d ] > > > > The AltiVec header file breaks boolean type: > > > > error: incompatible types when initializing type > > '__vector _bool int' {aka '_vector(4) __bool int'} using type 'int' > > > > If __APPLE_ALTIVEC__ is defined, then bool type is redefined > > and conflicts with stdbool.h. > > > > There is no good solution to fix it for the whole project without > > breaking something else, so a workaround is inserted in mlx5 PMD. > > This workaround is not compatible with C++ but there is no C++ in DPDK. > > > > Suggested-by: Christian Ehrhardt > > Suggested-by: Adrien Mazarguil > > Signed-off-by: Thomas Monjalon > > Tested-by: David Wilder > > Acked-by: Chao Zhu > > --- > > drivers/net/mlx5/mlx5_utils.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/net/mlx5/mlx5_utils.h > > index e48352f37..572296575 100644 > > --- a/drivers/net/mlx5/mlx5_utils.h > > +++ b/drivers/net/mlx5/mlx5_utils.h > > @@ -43,6 +43,16 @@ > > > > #include "mlx5_defs.h" > > > > +/* > > + * Compilation workaround for PPC64 when AltiVec is fully enabled, e.g. std=c11. > > + * Otherwise there would be a type conflict between stdbool and altivec. > > + */ > > +#if defined(__PPC64__) && !defined(__APPLE_ALTIVEC__) > > +#undef bool > > +/* redefine as in stdbool.h */ > > +#define bool _Bool > > +#endif > > + > > /* Bit-field manipulation. */ > > #define BITFIELD_DECLARE(bf, type, size) \ > > type bf[(((size_t)(size) / (sizeof(type) * CHAR_BIT)) + \ >