From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6861A0546 for ; Fri, 30 Apr 2021 22:10:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 803F541133; Fri, 30 Apr 2021 22:10:27 +0200 (CEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id C3F2F410EF for ; Fri, 30 Apr 2021 22:10:24 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id m37so7579221pgb.8 for ; Fri, 30 Apr 2021 13:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5sVy47CkzkYSogBZ8nzFvcv9wx78TSJRK6YjJHHTBb8=; b=JxLn48xlZAKbXX2GqrsA9jiheWS0ZPYoewuS67B7tCd9thYZTNx4P+4dqIPk49RU3J +5N9BtSmfcSS6E204Nz/584iEVvldv+36CjRBBRYRzx1cthUuInFE5WfkVm9yGmsj1he 6YE0g4Je6ixSYWCinNhoV3o4TwVbZipauPEjA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5sVy47CkzkYSogBZ8nzFvcv9wx78TSJRK6YjJHHTBb8=; b=FSXAFg+CC6HUVfMUbEQkDIQDRexWvhxRQxvMYfNWlgLH1TUaLOC3vhMICu9pNOmOD/ 3PZ30mvh5cg3HjzZSp9F+VVn2hK4oRd8KgcfH5cmvHpJUDnblgplOea+DI91ab/rYfnV /dYQxfeo7m2LwhDqw2Vu6xTUY1cZF8H+a+OgyV3kNrnZRBvll2YRyNOQkqtpDQQ3jWTS F1o3KJdE4lgMTC+4fudTezjhCTkjqARXwNm5NntKmNhU7DC0WsUTQysrSDjoMwZc3/jw Gu44B/CkfOwtcoxCJncWPj21tB2DAHBRKmUmciALd+L/xp2SuuM/dlMyOAw3WJUyCxWv kiug== X-Gm-Message-State: AOAM533+7YC6kuKIfjJk0Gb9KuSST1rszSakuCt74EsesBP/VfjmniNI zBvm4AHPZkwiTrhA8zdZC543FA== X-Google-Smtp-Source: ABdhPJyhkszKe+s9CmdBY5ljXRFKjjJH7IrVr7wXgHc0cTpxEN9ayjALAjSe6epWMZXRyOqArijbxw== X-Received: by 2002:a63:6a05:: with SMTP id f5mr6164125pgc.433.1619813423739; Fri, 30 Apr 2021 13:10:23 -0700 (PDT) Received: from u099.swdvt.lab.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id j12sm3430587pfc.17.2021.04.30.13.10.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Apr 2021 13:10:22 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Ajit Khaparde , stable@dpdk.org Date: Fri, 30 Apr 2021 13:14:11 -0700 Message-Id: <1619813653-5161-3-git-send-email-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1619813653-5161-1-git-send-email-ajit.khaparde@broadcom.com> References: <1619813653-5161-1-git-send-email-ajit.khaparde@broadcom.com> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000bf3c4c05c136338b" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-stable] [PATCH 2/4] net/bnxt: fix unchecked return value X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --000000000000bf3c4c05c136338b Return value where return value of rte_pci_read_config was not checked. Fix it. Coverity issue: 349919 Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 6dfb33c..4068271 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4129,13 +4129,17 @@ uint32_t bnxt_read_fw_status_reg(struct bnxt *bp, uint32_t index) struct bnxt_error_recovery_info *info = bp->recovery_info; uint32_t reg = info->status_regs[index]; uint32_t type, offset, val = 0; + int ret = 0; type = BNXT_FW_STATUS_REG_TYPE(reg); offset = BNXT_FW_STATUS_REG_OFF(reg); switch (type) { case BNXT_FW_STATUS_REG_TYPE_CFG: - rte_pci_read_config(bp->pdev, &val, sizeof(val), offset); + ret = rte_pci_read_config(bp->pdev, &val, sizeof(val), offset); + if (ret < 0) + PMD_DRV_LOG(ERR, "Failed to read PCI offset %#x", + offset); break; case BNXT_FW_STATUS_REG_TYPE_GRC: offset = info->mapped_status_regs[index]; -- 1.8.3.1 --000000000000bf3c4c05c136338b--