From: "Min Hu (Connor)" <humin29@huawei.com>
To: <stable@dpdk.org>
Cc: <christian.ehrhardt@canonical.com>
Subject: [dpdk-stable] [PATCH 19.11.9 3/3] net/hns3: fix handling link update
Date: Sat, 22 May 2021 14:47:24 +0800 [thread overview]
Message-ID: <1621666044-39902-3-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1621666044-39902-1-git-send-email-humin29@huawei.com>
From: Chengwen Feng <fengchengwen@huawei.com>
[ upstream commit fae9b062b01397339c02c88ebee11dd5f7af3e3c ]
The link fails code should be parsed using the structure
hns3_mbx_vf_to_pf_cmd, else it will parse fail.
Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/hns3/hns3_mbx.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c
index 896ad25..d44a4d1 100644
--- a/drivers/net/hns3/hns3_mbx.c
+++ b/drivers/net/hns3/hns3_mbx.c
@@ -315,8 +315,8 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code)
}
static void
-hns3_handle_link_change_event(struct hns3_hw *hw,
- struct hns3_mbx_pf_to_vf_cmd *req)
+hns3pf_handle_link_change_event(struct hns3_hw *hw,
+ struct hns3_mbx_vf_to_pf_cmd *req)
{
#define LINK_STATUS_OFFSET 1
#define LINK_FAIL_CODE_OFFSET 2
@@ -455,7 +455,14 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
hns3_mbx_handler(hw);
break;
case HNS3_MBX_PUSH_LINK_STATUS:
- hns3_handle_link_change_event(hw, req);
+ /*
+ * This message is reported by the firmware and is
+ * reported in 'struct hns3_mbx_vf_to_pf_cmd' format.
+ * Therefore, we should cast the req variable to
+ * 'struct hns3_mbx_vf_to_pf_cmd' and then process it.
+ */
+ hns3pf_handle_link_change_event(hw,
+ (struct hns3_mbx_vf_to_pf_cmd *)req);
break;
default:
hns3_err(hw, "received unsupported(%d) mbx msg",
--
2.7.4
next prev parent reply other threads:[~2021-05-22 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 6:47 [dpdk-stable] [PATCH 19.11.9 1/3] net/hns3: fix HW buffer size on MTU update Min Hu (Connor)
2021-05-22 6:47 ` [dpdk-stable] [PATCH 19.11.9 2/3] net/hns3: fix processing Tx offload flags Min Hu (Connor)
2021-05-22 6:47 ` Min Hu (Connor) [this message]
2021-05-31 8:41 ` [dpdk-stable] [PATCH 19.11.9 1/3] net/hns3: fix HW buffer size on MTU update Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1621666044-39902-3-git-send-email-humin29@huawei.com \
--to=humin29@huawei.com \
--cc=christian.ehrhardt@canonical.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).