patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Jiayu Hu <jiayu.hu@intel.com>
To: dev@dpdk.org
Cc: maxime.coquelin@redhat.com, chenbo.xia@intel.com,
	Jiayu Hu <jiayu.hu@intel.com>,
	stable@dpdk.org
Subject: [dpdk-stable] [PATCH v5 1/3] vhost: fix lock on device readiness notification
Date: Fri, 16 Jul 2021 15:51:27 -0400	[thread overview]
Message-ID: <1626465089-17052-2-git-send-email-jiayu.hu@intel.com> (raw)
In-Reply-To: <1626465089-17052-1-git-send-email-jiayu.hu@intel.com>

The vhost notifies the application of device readiness via
vhost_user_notify_queue_state(), but calling this function
is not protected by the lock. This patch is to make this
function call lock protected.

Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications")
Cc: stable@dpdk.org

Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 lib/vhost/vhost_user.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 031c578..31300e1 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -2995,9 +2995,6 @@ vhost_user_msg_handler(int vid, int fd)
 		}
 	}
 
-	if (unlock_required)
-		vhost_user_unlock_all_queue_pairs(dev);
-
 	/* If message was not handled at this stage, treat it as an error */
 	if (!handled) {
 		VHOST_LOG_CONFIG(ERR,
@@ -3032,6 +3029,8 @@ vhost_user_msg_handler(int vid, int fd)
 		}
 	}
 
+	if (unlock_required)
+		vhost_user_unlock_all_queue_pairs(dev);
 
 	if (!virtio_is_ready(dev))
 		goto out;
-- 
2.7.4


  parent reply	other threads:[~2021-07-16 13:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1622189463-392610-1-git-send-email-jiayu.hu@intel.com>
2021-05-28  8:11 ` [dpdk-stable] [PATCH 1/2] " Jiayu Hu
2021-07-02  7:36   ` Maxime Coquelin
     [not found]   ` <1625656687-40604-1-git-send-email-jiayu.hu@intel.com>
2021-07-07 11:18     ` [dpdk-stable] [PATCH v2 1/3] " Jiayu Hu
     [not found]       ` <1625823790-91995-1-git-send-email-jiayu.hu@intel.com>
2021-07-09  9:43         ` [dpdk-stable] [PATCH v3 " Jiayu Hu
     [not found]           ` <1626162383-89674-1-git-send-email-jiayu.hu@intel.com>
2021-07-13  7:46             ` [dpdk-stable] [PATCH v4 " Jiayu Hu
     [not found]               ` <1626465089-17052-1-git-send-email-jiayu.hu@intel.com>
2021-07-16 19:51                 ` Jiayu Hu [this message]
     [not found]                   ` <1626706847-276163-1-git-send-email-jiayu.hu@intel.com>
2021-07-19 15:00                     ` [dpdk-stable] [PATCH v6 " Jiayu Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1626465089-17052-2-git-send-email-jiayu.hu@intel.com \
    --to=jiayu.hu@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).