From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6BD28A0AC5 for ; Thu, 2 May 2019 23:39:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E98A1B108; Thu, 2 May 2019 23:39:57 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D3114D0B2; Thu, 2 May 2019 23:39:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 27A4025CDE; Thu, 2 May 2019 17:39:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 May 2019 17:39:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=5I36IJmP8wK6hPJ4ZoD1T9BjVsIhI8D/mqkkypZIAAY=; b=rbiLpE0NpJT3 ssAWPg9Sr3zIlr8ll+y22/NGmAHKEmQKJU+0gZrhP0xrt03JLkWoJCvdyh44/zRI eSxgpByLOkWJ9LZH6VgGfj/xyzEX9WmKwTQPTT3QCobbu8TV61y+UX2xM8t2PBPG Od6Qw0jAF/m9YZax8q5U10pGCc6gfxs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5I36IJmP8wK6hPJ4ZoD1T9BjVsIhI8D/mqkkypZIA AY=; b=EKLGmr+PFI+nAw2CDe0Q3hnMHTKF1eT/o923rBe1D5aI5oMvhIc/n1Wjj Kur/Fi2ptU6yH6SZybI+3J8O6PBk9glNo1WAvQU/Eh7bdYj+Xlw0l69Z4VWR9CPX 0eFT1Aa6x3Qdy3P1qeIKk8faQsatdCN8bGEmf4EyWWwHBu8YYj5+HnDrUpgVM+mm zSvWk8fppDgzj6v8uq9RhFwc0ftkky3qW9DWFYTdxVO1frK9fT51TfzEEBHQ3f/x Z/FK6lyMQ+3aOZKJsfGldze6oYYEUMb9HURO08ZwyuI6YL89zejvF/b+5QH4maPI 2V77U7YRvMKIFCcu3ydI8VB0LeNdg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedtucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejje drudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghs sehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 58ADDE432B; Thu, 2 May 2019 17:39:50 -0400 (EDT) From: Thomas Monjalon To: Li Qiang Cc: stable@dpdk.org, "Xu, Rosen" , "Zhang, Tianfei" , "dev@dpdk.org" , "liq3ea@gmail.com" Date: Thu, 02 May 2019 23:39:49 +0200 Message-ID: <1646069.sVXKPgHgFL@xps> In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A6B02B5@SHSMSX104.ccr.corp.intel.com> References: <20190416050514.2784-1-liq3ea@163.com> <0E78D399C70DA940A335608C6ED296D73A6B02B5@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > > In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed > > thus leading a fd leak. This patch avoids this. > > > > Coverity issue: 279441 > > Fixes: ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver") > > Cc: stable@dpdk.org > > > > Signed-off-by: Li Qiang > > Acked-by: Rosen Xu Applied, thanks