From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67C9CA09E4 for ; Fri, 5 Feb 2021 21:05:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58638188A0E; Fri, 5 Feb 2021 21:05:52 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id D4FF34067B; Fri, 5 Feb 2021 21:05:49 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id E6BC993E; Fri, 5 Feb 2021 15:05:47 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 05 Feb 2021 15:05:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= M2fkbsqPl+e8ao7rJ0GAzwdelG805ekqKYr9DQhXHfo=; b=KCEhCPZGnFkdqlQV Q6AU5JDYCQB9uePXCeE9QU8HD/xUMDSblS16vXL2AAbw+oW7ghh6MvlKhRBpOkoL Y+kYKoWXKSDpPgVqBL7+G82Fs1M5/eoL24TNu/2usoBngimnpSTBaCNcMpmoqDmk DHTSvWKgAGfs2Dpc/h+g119/tpIICjlNxa9emdEadmGqnHyLdhTerROMOTYMFb9g TfgpsIZn2y5zU1SbXz/Vac8nZG6Yj6kmz2gHW+S9H+2xzNDxPs1ch0MWd2jTnz1X TIVTTcA7jMyNVNKgLa+P8PmTqv1AiFmIJEWr1tRR+0ErES1v0gXRK0dQxB78ar4x PpozJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=M2fkbsqPl+e8ao7rJ0GAzwdelG805ekqKYr9DQhXH fo=; b=gvgsadRhpok8nLh6/MnS86//MDnj6OFoa6MSsUYLIfJwUIQVtDQYLtotZ +DoivrnYd4VruPYcQXjGKsm6K+fNmtD9iS2ajKbWXGfGg1DX7iABb/+/jzdsPGL6 UkybPaKl9NNM3AjqfZts45sqWwDmICRm1TTMQlmQcLfH/M+wssH4+kefZqFyRQlG mnNtfk4075rIrGZU/ke4qEnD/a+K4sdTBy1ogw709ula04NxOQdBBnT9lirS9w+l SC0Rva2pcr5TpHnp5KBP304ezrDekReDfJwuobP+A3VRLPzluMLqBsMgyqEncuAx MpctTorUBrXiiJ2JhYh+dq9dD9OfQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeeigdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3FCE81080059; Fri, 5 Feb 2021 15:05:45 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, Bruce Richardson , stable@dpdk.org, Ray Kinsella , Neil Horman , Kevin Laatz Date: Fri, 05 Feb 2021 21:05:43 +0100 Message-ID: <1695007.lsEMqjsl9x@thomas> In-Reply-To: <20210205193933.410011-1-bruce.richardson@intel.com> References: <20210205193933.410011-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH] eal: fix querying DPDK version at runtime X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 05/02/2021 20:39, Bruce Richardson: > For using a DPDK application, such as OVS, which is dynamically linked, the > DPDK version in use should always report the actual version, not the > version used at build time. This incorrect behaviour can be seen by > building OVS against one version of DPDK and running it against a later > one. Using "ovs-vsctl list Open_vSwitch" to query basic info, the > dpdk_version returned will be the build version not the currently running > one - which can be verified using the DPDK telemetry library client. > > $ sudo ovs-vsctl list Open_vSwitch | grep dpdk_version > dpdk_version : "DPDK 20.11.0-rc4" > > $ echo quit | sudo dpdk-telemetry.py > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > {"version": "DPDK 21.02.0-rc2", "pid": 405659, "max_output_len": 16384} Nice demonstration. > __rte_experimental > int > -rte_telemetry_init(const char *runtime_dir, rte_cpuset_t *cpuset, > +rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset, > const char **err_str); It is changing the API. As it is experimental, you just need to mention it in the release notes. It is the fix. Do you think it should be merged quickly? Or wait for 21.05?