patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2] pdump: fix vdev cleanup
@ 2019-01-11 17:41 Reshma Pattan
  2019-01-11 17:51 ` [dpdk-stable] [PATCH v3] " Reshma Pattan
  0 siblings, 1 reply; 10+ messages in thread
From: Reshma Pattan @ 2019-01-11 17:41 UTC (permalink / raw)
  To: dev; +Cc: reshmapa, stable, ferruh.yigit

From: reshmapa <reshma.pattan@intel.com>

Virtual devices added in pdump application
using rte_eal_hotplug_add should be removed explicitly
while existing the pdump application, otherwise the
subsequent run of the pdump application will fail with the reason
that virtual devices with the same name already exists in primary.

Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev attach")
CC: stable@dpdk.org
CC: ferruh.yigit@intel.com

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
v2: fix typo in commit message
---
 app/pdump/main.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index 9e86bf623..5e183ea90 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -494,6 +494,7 @@ cleanup_pdump_resources(void)
 {
 	int i;
 	struct pdump_tuples *pt;
+	char name[RTE_ETH_NAME_MAX_LEN];
 
 	/* disable pdump and free the pdump_tuple resources */
 	for (i = 0; i < num_tuples; i++) {
@@ -510,6 +511,14 @@ cleanup_pdump_resources(void)
 			free_ring_data(pt->rx_ring, pt->rx_vdev_id, &pt->stats);
 		if (pt->dir & RTE_PDUMP_FLAG_TX)
 			free_ring_data(pt->tx_ring, pt->tx_vdev_id, &pt->stats);
+
+		/* Remove the vdev created */
+		rte_eth_dev_get_name_by_port(pt->rx_vdev_id, name);
+		rte_eal_hotplug_remove("vdev", name);
+
+		rte_eth_dev_get_name_by_port(pt->tx_vdev_id, name);
+		rte_eal_hotplug_remove("vdev", name);
+
 	}
 	cleanup_rings();
 }
-- 
2.17.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-01-17 20:28 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 17:41 [dpdk-stable] [PATCH v2] pdump: fix vdev cleanup Reshma Pattan
2019-01-11 17:51 ` [dpdk-stable] [PATCH v3] " Reshma Pattan
2019-01-15  0:59   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-01-15 10:09     ` Pattan, Reshma
2019-01-15 10:10       ` Thomas Monjalon
2019-01-15 10:25         ` Pattan, Reshma
2019-01-17 20:23           ` Thomas Monjalon
2019-01-15 13:45   ` [dpdk-stable] [PATCH v4] " Reshma Pattan
2019-01-15 14:57     ` Ferruh Yigit
2019-01-17 20:28       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).