From: Thomas Monjalon <firstname.lastname@example.org> To: Ferruh Yigit <email@example.com>, Christian Ehrhardt <firstname.lastname@example.org> Cc: dev <email@example.com>, dpdk stable <firstname.lastname@example.org>, Thomas Bogendoerfer <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, Marco Varlese <firstname.lastname@example.org> Subject: Re: [dpdk-stable] [PATCH] kni: fix compilation on SLES15-SP3 Date: Thu, 17 Jun 2021 08:41:44 +0200 Message-ID: <1708042.2qKnxoAoZE@thomas> (raw) In-Reply-To: <CAATJJ0KeOY0GZ34KX9N-cX2oQt4=9TBuLrSN5iJORLP+TV3RgQ@mail.gmail.com> 17/06/2021 08:14, Christian Ehrhardt: > On Thu, Jun 10, 2021 at 12:30 PM Christian Ehrhardt > <email@example.com> wrote: > > On Thu, Jun 10, 2021 at 10:39 AM Christian Ehrhardt > > <firstname.lastname@example.org> wrote: > > > On Tue, Jun 8, 2021 at 1:17 PM Ferruh Yigit <email@example.com> wrote: > > > > On 6/2/2021 3:33 PM, Christian Ehrhardt wrote: > > > > > Like what was done for mainline kernel in commit 38ad54f3bc76 ("kni: fix > > > > > build with Linux 5.6"), a new parameter 'txqueue' has to be added to > > > > > 'ndo_tx_timeout' ndo on SLES 15-SP3 kernel. > > > > > > > > > > Caused by: > > > > > commit c3bf155c40e9db722feb8a08c19efd44c12d5294 > > > > > Author: Thomas Bogendoerfer <firstname.lastname@example.org> > > > > > Date: Fri Sep 11 16:08:31 2020 +0200 > > > > > - netdev: pass the stuck queue to the timeout handler > > > > > (jsc#SLE-13536). > > > > > - Refresh patches.suse/sfc-move-various-functions.patch. > > > > > > > > > > That is part of the SLES 5.3.18 kernel and therefore the > > > > > version we check for. > > > > > > > > > > Cc: email@example.com > > > > > > > > > > Signed-off-by: Christian Ehrhardt <firstname.lastname@example.org> > > > > > > > > Hi Christian, > > > > > > > > There is a build error reported in CI  with 'SUSE15-64'. > > > > Can't the check 'linux version >= 5.3.18" may hit multiple SUSE versions, with > > > > some has the patch mentioned above backported and some did not? > > > > Can 'SLE_VERSION_CODE' be used to differentiate the SUSE versions? > > > > > > I don't have a perfect insight in the SUSE distro variants and their > > > kernel versions. > > > > 5.3.18 in SLES15-SP3 was what broke it and I have hoped that this would apply in general. > > > But the error above seems we have others that are > 5.3.18 but at the > > > same time not have the backport. > > > > > > I'll try to create a v3, but do we have anyone from Suse to usually > > > directly ping for feedback on this? > > > > With the new version (not submitted since it fails me) you can have a > > look at my personal WIP branch: > > => https://github.com/cpaelzer/dpdk-stable-queue/commit/43b908fe83e9cd68b08e259c0ace26ec692bb737 > > Hello everyone, > Ferruh and I reached out to the Suse people working on DPDK in the > past as well as those doing the kernel backport that breaks it now. > (I'll add them to CC here as well) > Unfortunately there was no feedback in a week, but OTOH I also don't > want to stall releases for too long due to this. > > I'll try to summarize the current understanding of this case again > >  breaks our KNI build. > > SLE_VERSION isn't provided by their Kernel; it is in DPDKs > kernel/linux/kni/compat.h and not further maintained for a while. > So we can't differentiate SLE15SP2 vs SLE15SP3 via that. > > The offending change was introduced in their kernel by  > $ git tag --contains c3bf155c40e9 | sort | head > rpm-5.3.18-24 > ... > > But checking just the kernel version 5.3.18 (as my initial patch had) > won't work either. > The problem is that this only checks the three levels of kernel > version, but not the packaging level. > And to make things even more fun, while I don't know if opensuse leap > has the patch applied or not atm, but the kernel version there might > make this even more complex as it is 5.3.18-lp152 at the moment. > > We have now: > SLE15 SP2 5.3.18-22 > SLE15 SP3 5.3.18-57 (>=24) > opensuse_leap 5.3.18-lp152 > > Without a change SLE15SP3 is broken due to that backport. > By checking on >=5.3.18 we could fix SP3, but break SP2 and maybe opensuse_leap. > > Maybe there is something on LOCALVERSION/EXTRAVERSION we can use, but > "guessing" how the Suse kernel behaves isn't a good approach. > Once Suse lets us know how to better differentiate their packaging > version we can reconsider a proper fix for this. > > But without further input from Suse I'd (for now) ask to keep things > as is (= not applying my patch). > Due to that it will build in the same places it has built in the past. > If we find a solution it can be in the next release in ~3 months, but > I'll not further stall e.g. 19.11.9 that I'm working on right now. > > : https://github.com/SUSE/kernel/commit/c3bf155c40e9 Thank you for the summary. This explains well why we should stop supporting KNI.
next prev parent reply other threads:[~2021-06-17 6:41 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-02 14:33 Christian Ehrhardt 2021-06-04 13:02 ` [dpdk-stable] [dpdk-dev] " Luca Boccassi 2021-06-08 11:17 ` [dpdk-stable] " Ferruh Yigit 2021-06-10 8:39 ` Christian Ehrhardt 2021-06-10 10:30 ` Christian Ehrhardt 2021-06-17 6:14 ` Christian Ehrhardt 2021-06-17 6:41 ` Thomas Monjalon [this message] 2021-06-17 8:24 ` Marco Varlese 2021-07-01 8:23 ` Christian Ehrhardt 2021-07-01 13:24 ` Christian Ehrhardt 2021-10-25 19:59 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1708042.2qKnxoAoZE@thomas \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ email@example.com public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git