patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] eal: initialize alarms early
@ 2019-03-26 18:43 Darek Stojaczyk
  2019-03-27 18:11 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  2019-04-01 14:18 ` [dpdk-stable] [PATCH v2] " Darek Stojaczyk
  0 siblings, 2 replies; 10+ messages in thread
From: Darek Stojaczyk @ 2019-03-26 18:43 UTC (permalink / raw)
  To: dev; +Cc: Darek Stojaczyk, Qi Zhang, Anatoly Burakov, stable

We currently initialize rte_alarms after starting
to listen for IPC hotplug requests, which gives
us a data race window. Upon receiving such hotplug
request we always try to set an alarm and this
obviously doesn't work if the alarms weren't
initialized yet.

To fix it, we initialize alarms before starting
to listen for IPC hotplug messages. Specifically,
we move rte_eal_alarm_init() right after
rte_eal_intr_init() as it makes some sense to
keep those two close to each other.

Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
Cc: Qi Zhang <qi.z.zhang@intel.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: stable@dpdk.org

Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
---
 lib/librte_eal/linux/eal/eal.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
index 13f401684..75ed0cf10 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -1005,6 +1005,12 @@ rte_eal_init(int argc, char **argv)
 		return -1;
 	}
 
+	if (rte_eal_alarm_init() < 0) {
+		rte_eal_init_alert("Cannot init interrupt-handling thread");
+		/* rte_eal_alarm_init sets rte_errno on failure. */
+		return -1;
+	}
+
 	/* Put mp channel init before bus scan so that we can init the vdev
 	 * bus through mp channel in the secondary process before the bus scan.
 	 */
@@ -1125,12 +1131,6 @@ rte_eal_init(int argc, char **argv)
 		return -1;
 	}
 
-	if (rte_eal_alarm_init() < 0) {
-		rte_eal_init_alert("Cannot init interrupt-handling thread");
-		/* rte_eal_alarm_init sets rte_errno on failure. */
-		return -1;
-	}
-
 	if (rte_eal_timer_init() < 0) {
 		rte_eal_init_alert("Cannot init HPET or TSC timers");
 		rte_errno = ENOTSUP;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-04-02 13:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-26 18:43 [dpdk-stable] [PATCH] eal: initialize alarms early Darek Stojaczyk
2019-03-27 18:11 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-03-27 20:33   ` Stojaczyk, Dariusz
2019-03-27 22:42     ` Thomas Monjalon
2019-03-28 10:43       ` Bruce Richardson
2019-03-28 10:46         ` Thomas Monjalon
2019-03-28 13:14           ` Burakov, Anatoly
2019-04-01 14:22     ` Stojaczyk, Dariusz
2019-04-01 14:18 ` [dpdk-stable] [PATCH v2] " Darek Stojaczyk
2019-04-02 13:01   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).