patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
Cc: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2 04/13] app/test: fix macro definition
Date: Wed, 08 Apr 2020 19:47:56 +0200	[thread overview]
Message-ID: <1777512.atdPhlSkOF@thomas> (raw)
In-Reply-To: <fa64b781-a155-c671-2573-600d7163d8c0@partner.samsung.com>

08/04/2020 18:15, Lukasz Wojciechowski:
> Hi Thomas,
> 
> Before my patch there was just a definition:
> #define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE
> without #ifndef condition.
> 
> It caused a build problem to me when working on security test, which 
> uses both rte_test.h and test.h
> As libraries should go first on the include list before local files I used:
> 
> #include <rte_test.h>
> #include "test.h"
> 
> sequence, which cause obvious build error as RTE_TEST_TRACE_FAILURE was 
> first defined as an empty macro inside rte_test.h, and redefinition in 
> test.h caused a problem.
> 
> 
> So I had two ways to solve the issue:
> 1) to wrap it with #ifndef condition and leave the definition there
> 2) to remove the redefinition from test.h
> 
> I've chosen the 1) solution because:
> * Author of the former patch had placed the definition there for some 
> purpose

Because rte_test.h is more recent and its addition was not complete enough.
rte_test.h should be included in test.h, and overlaps removed.

> * In my opinion it is better to have the definition present and pointing 
> to the same macro for both RTE_TEST_TRACE_FAILURE and TEST_TRACE_FAILURE 
> as it would make logs look more consistent when printing information the 
> same way.

I think solution 2 is better.


PS: please avoid top-posting


> W dniu 08.04.2020 o 14:53, Thomas Monjalon pisze:
> > 08/04/2020 05:13, Lukasz Wojciechowski:
> >> Wrap RTE_TEST_TRACE_FAILURE macro definition into #ifndef clause
> >> as it might be already defined.
> > I think it should not be defined at all.
> > Why not including rte_test.h?
> >
> >
> >
> 






  reply	other threads:[~2020-04-08 17:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200312151654.7218-1-l.wojciechow@partner.samsung.com>
     [not found] ` <20200408031351.4288-1-l.wojciechow@partner.samsung.com>
     [not found]   ` <CGME20200408031447eucas1p1376332353faa0d217e7be8c32271405f@eucas1p1.samsung.com>
2020-04-08  3:13     ` [dpdk-stable] [PATCH v2 01/13] security: fix verification of parameters Lukasz Wojciechowski
2020-04-08 12:54       ` Thomas Monjalon
2020-04-08 13:02         ` [dpdk-stable] [dpdk-dev] " Anoob Joseph
2020-04-08 13:26           ` Thomas Monjalon
2020-04-08 14:44             ` [dpdk-stable] [EXT] " Anoob Joseph
2020-04-08 15:49               ` Lukasz Wojciechowski
2020-04-08 17:51                 ` Thomas Monjalon
2020-04-09 10:14                   ` Bruce Richardson
2020-04-09 10:54                     ` Thomas Monjalon
2020-04-09 11:13                       ` Bruce Richardson
2020-04-09 14:07                         ` Lukasz Wojciechowski
2020-04-09 14:21                           ` Lukasz Wojciechowski
2020-04-09 15:22                             ` Thomas Monjalon
2020-04-09 16:10                               ` Lukasz Wojciechowski
2020-04-10  8:45                                 ` Bruce Richardson
     [not found]   ` <CGME20200408031448eucas1p2b36997fc73f5b5e2aadb6e4bb965063b@eucas1p2.samsung.com>
2020-04-08  3:13     ` [dpdk-stable] [PATCH v2 02/13] security: fix return types in documentation Lukasz Wojciechowski
     [not found]   ` <CGME20200408031448eucas1p2d6df7ff419bb093606a2f9115297f45a@eucas1p2.samsung.com>
2020-04-08  3:13     ` [dpdk-stable] [PATCH v2 03/13] security: fix session counter Lukasz Wojciechowski
     [not found]   ` <CGME20200408031449eucas1p1ca89719463cbaf29e9f7c81beaec88c2@eucas1p1.samsung.com>
2020-04-08  3:13     ` [dpdk-stable] [PATCH v2 04/13] app/test: fix macro definition Lukasz Wojciechowski
2020-04-08 12:53       ` Thomas Monjalon
2020-04-08 16:15         ` Lukasz Wojciechowski
2020-04-08 17:47           ` Thomas Monjalon [this message]
2020-04-09 14:10             ` Lukasz Wojciechowski
     [not found]   ` <20200409172502.1693-1-l.wojciechow@partner.samsung.com>
     [not found]     ` <CGME20200409172529eucas1p1f02aaf66052f45ac75ba9e9f63ef1c3a@eucas1p1.samsung.com>
2020-04-09 17:24       ` [dpdk-stable] [PATCH v3 01/13] security: fix verification of parameters Lukasz Wojciechowski
2020-04-13 15:42         ` [dpdk-stable] [dpdk-dev] " Anoob Joseph
     [not found]     ` <CGME20200409172530eucas1p27297a83a9d7508e3f8a8f88850cbe37c@eucas1p2.samsung.com>
2020-04-09 17:24       ` [dpdk-stable] [PATCH v3 02/13] security: fix return types in documentation Lukasz Wojciechowski
2020-04-13 15:43         ` [dpdk-stable] [dpdk-dev] " Anoob Joseph
     [not found]     ` <CGME20200409172531eucas1p1c3ec21532e5e232ff2d68d56f096e71c@eucas1p1.samsung.com>
2020-04-09 17:24       ` [dpdk-stable] [PATCH v3 03/13] security: fix session counter Lukasz Wojciechowski
2020-04-13 15:48         ` [dpdk-stable] [dpdk-dev] " Anoob Joseph
     [not found]     ` <CGME20200409172532eucas1p285bc6767be1d62a0098d177a7757169f@eucas1p2.samsung.com>
2020-04-09 17:24       ` [dpdk-stable] [PATCH v3 04/13] app/test: remove macro definition Lukasz Wojciechowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1777512.atdPhlSkOF@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=l.wojciechow@partner.samsung.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).