From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27D71A0C47 for ; Mon, 12 Apr 2021 17:29:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D365F141257; Mon, 12 Apr 2021 17:29:04 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 2913D14124D; Mon, 12 Apr 2021 17:29:02 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 9E6F25C0194; Mon, 12 Apr 2021 11:28:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 12 Apr 2021 11:28:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= DlZ8Mgmx3yG7u3GVZjm/d+Bfg9jSAwNpTzRVE+Kn7rI=; b=ah6Wn8Ptx920j/qW YpzkCoEalH6u2gnCRrXkIzXf/iiT+T08lGOHPkWPqkwBN1gh8EJ0Ds5cZagybaTo EL8D0TCUN8SiltKo2a5n6yrcJhfv1S4x/hMMMkB6Uyuj2YJJPGjCEdthHyF7Z4Ve W2gOUIOB3+OdUd8VQmK+mpMXvRZpsRaii35AjklfBMzIwiiizI9cYcYKZV62aZQc dCMYoZ1goibcIQ5xwJv5E0cfNp/oRF75cJT0nLaQBwZovIkF3DLug4XOPBP10VN9 6EDPC1dlryV2K6KAWrxI+8Nq9rhVgMKUTDrTNDGek+xXvZhLabj+ANOEqkYjCZiE efdiIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=DlZ8Mgmx3yG7u3GVZjm/d+Bfg9jSAwNpTzRVE+Kn7 rI=; b=n/lkehOKenigxlfQvz2QsNccuYFGo+gE3rfvFaW6lkEnkD4pNvCuzY9kl nWmWtk8kK+hmUmnTE4gQlmVpqWVPjkrQ3lGT49wfOoDExFqwMlkQHCEyKE2J6KSU iS+ai7BZ3eZ7TYIWageSh3rZaU1FV0bxUVAQCWf0jyeAr4KQW1znAoZE9jhrPvBc zS49rx93OUqlp9iP/y+VzbX6A6Q3QZ/ua7KxRJdojY85XhX9HN/DwWRVoiXxEN2L ukOppW4lzPzVSKQgHWGuuggGO09dysGeNNZK2Y37bjU3eFJn9uo/vI6nqfSRut80 rMKn0jgE70m5fKMSkDSPY+tH3w4Qw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekjedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6994F24005B; Mon, 12 Apr 2021 11:28:57 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com, asafp@nvidia.com, wisamm@nvidia.com, stable@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com Date: Mon, 12 Apr 2021 17:28:55 +0200 Message-ID: <1831781.UOzqvqydHp@thomas> In-Reply-To: <20210411122136.2560-1-talshn@nvidia.com> References: <20210411122136.2560-1-talshn@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 11/04/2021 14:21, Tal Shnaiderman: > Several functions introduced in the addition of the Windows support to > mlx5 were missing the __rte_internal tag although being exported. > > Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows") > Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on Windows") > Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows") > Cc: stable@dpdk.org > > Signed-off-by: Tal Shnaiderman It is fixing Linux debug build (note: should be added to CI). Applied in main tree with this message, thanks: common/mlx5: add missing internal tags Several functions introduced in the addition of the Windows support to mlx5 were missing the __rte_internal tag. This miss is better revealed when symbols became exported on Linux too, and it is caught by the symbol checker with --buildtype=debug. Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows") Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on Windows") Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows") Fixes: 56ea803e878e ("build: remove Windows export symbol list") Cc: stable@dpdk.org Signed-off-by: Tal Shnaiderman