patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix leak in shared lib mode detection
Date: Mon, 10 May 2021 15:18:55 +0200
Message-ID: <1837679.WkC7EDQrBm@thomas> (raw)
In-Reply-To: <YJPHhTNOj2C0riLr@bricha3-MOBL.ger.corp.intel.com>

06/05/2021 12:40, Bruce Richardson:
> On Thu, May 06, 2021 at 12:06:37PM +0200, David Marchand wrote:
> > This is reported by our internal covscan:
> > 
> > 1. dpdk-20.11/lib/librte_eal/common/eal_common_options.c:508: alloc_fn:
> > Storage is returned from allocation function "dlopen".
> > 6. dpdk-20.11/lib/librte_eal/common/eal_common_options.c:508:
> > leaked_storage: Failing to save or free storage allocated by
> > "dlopen("librte_eal.so.21.0", 5)" leaks it.
> > 
> >  #   506|   	 * shared library is not already loaded i.e. it's
> >  #   statically linked.)
> >  #   507|   	 */
> >  #   508|-> 	if (dlopen("librte_eal.so."ABI_VERSION, RTLD_LAZY |
> >  #   RTLD_NOLOAD) != NULL &&
> >  #   509|   			*default_solib_dir != '\0' &&
> >  #   510|   			stat(default_solib_dir, &sb) == 0 &&
> > 
> > This leak is not an issue per se, but on the other hand, this is easy
> > to fix and I prefer not having to waive this warning later.
> > 
> > Fixes: 06c7871dde01 ("eal: restrict default plugin path to shared lib mode")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks




      reply	other threads:[~2021-05-10 13:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 10:06 [dpdk-stable] " David Marchand
2021-05-06 10:40 ` Bruce Richardson
2021-05-10 13:18   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1837679.WkC7EDQrBm@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git