patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: nipun.gupta@nxp.com
Cc: dev@dpdk.org, jerry.lilijun@huawei.com, xudingke@huawei.com,
	Yunjian Wang <wangyunjian@huawei.com>,
	stable@dpdk.org, wangyunjian <wangyunjian@huawei.com>,
	hemant.agrawal@nxp.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
Date: Tue, 06 Oct 2020 23:33:41 +0200
Message-ID: <1857423.J520cpIJeM@thomas> (raw)
In-Reply-To: <1599613906-19420-1-git-send-email-wangyunjian@huawei.com>

Nipun, could you review please?

09/09/2020 03:11, wangyunjian:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> This issue detected by coverity, CID#279443(Structurally dead code).
> 
> Coverity issue: 279443
> Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v2: fix spelling in commit log
> ---
>  drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> index 0b9c4e3d7..4b8474951 100644
> --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> @@ -452,9 +452,10 @@ rte_qdma_reset(void)
>  	/* In case there are pending jobs on any VQ, return -EBUSY */
>  	for (i = 0; i < qdma_dev.max_vqs; i++) {
>  		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
> -		    qdma_vqs[i].num_dequeues))
> +		    qdma_vqs[i].num_dequeues)) {
>  			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i);
>  			return -EBUSY;
> +		}
>  	}
>  
>  	/* Reset HW queues */
> 






  reply	other threads:[~2020-10-06 21:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 13:41 [dpdk-stable] [dpdk-dev] [PATCH] " wangyunjian
2020-09-09  1:11 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " wangyunjian
2020-10-06 21:33   ` Thomas Monjalon [this message]
2020-10-07  5:35   ` Nipun Gupta
2020-10-11 20:06     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1857423.J520cpIJeM@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerry.lilijun@huawei.com \
    --cc=nipun.gupta@nxp.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git