From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1437FA0AC5 for ; Fri, 3 May 2019 01:32:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C916E5F1C; Fri, 3 May 2019 01:32:56 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 9EAE65B1E; Fri, 3 May 2019 01:32:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id EA1F8D8A2; Thu, 2 May 2019 19:32:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 02 May 2019 19:32:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BaoDwcA2NsNI1nGkKtpdrX5JcOQjK5/Hm48wWHbZw6Q=; b=qmcLR5SDTSq+ yEg4a+MRESaBgmhA8T3qge+eRb/tFggtvEIdxE2Cc9INugM7dm9fR9vsytNrtZlp UDmlhXOm80ypsf+o9zjTMWPNWU/7ox/+Nxqgp1GkxExwol74L56agzJlgZ1wOinw s5Qfx5g98n3vrgO8ffVH+pYbb68xotk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=BaoDwcA2NsNI1nGkKtpdrX5JcOQjK5/Hm48wWHbZw 6Q=; b=jtAEwGfDDAC8Y5oluD4sijuslIcu/+qx2oKpeJYMA5ee1wqGbsmz6+ho3 LDuovVqwyHX7jzTqTHDt9p3qpRf58FdkbBuvPQT0+e2Lj4F8YZrYfGcy2oKt540I nH0RF+kDwOucOSClFleM71ZiRqZFe9faTsWhZ6Bnv4+95I5FCwkUs8b291fsk1J4 GmZtHecjeidxxDCTnaPiV9KY+Z9RRl7b5ILF3mUevs7rB4qhxiDnvjlHA909Yvzp ZHpbgLutcufikMriztIOYn8PyW1s2Y2Ev2IbskUAn4O9PMzqUz8ERpj3jo5W8OqL XL6KBa/OEl4bYIBW6P3zx5xxPE4Hw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedtgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A844F1037C; Thu, 2 May 2019 19:32:50 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: dev@dpdk.org, Jerin Jacob Kollanukkaran , Marko Kovacevic , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "stable@dpdk.org" Date: Fri, 03 May 2019 01:32:49 +0200 Message-ID: <1860264.T1sj13Lf8p@xps> In-Reply-To: <20190410072836.17496-1-pbhagavatula@marvell.com> References: <20190410072836.17496-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 10/04/2019 09:29, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Currently, l3wfd em mode has two datapath modes em_sequential and > em_hlm. We can select either of them by defining NO_HASH_MULTI_LOOKUP to > one or zero. > The code checks if NO_HASH_MULTI_LOOKUP is defined or not instead of > checking for the value. > > Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") > Cc: stable@dpdk.org > > Signed-off-by: Pavan Nikhilesh > --- > --- a/examples/l3fwd/l3fwd_em.c > +++ b/examples/l3fwd/l3fwd_em.c > #if defined RTE_ARCH_X86 || defined RTE_MACHINE_CPUFLAG_NEON > -#if defined(NO_HASH_MULTI_LOOKUP) > +#if NO_HASH_MULTI_LOOKUP It does not compile: examples/l3fwd/l3fwd_em.c:302:5: error: 'NO_HASH_MULTI_LOOKUP' is not defined, evaluates to 0 [-Werror,-Wundef] #if NO_HASH_MULTI_LOOKUP Anyway such compilation option should be just removed. Please replace it with a runtime option and/or make it documented. Thanks