From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAF0E43CA0 for ; Wed, 13 Mar 2024 13:09:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD4AF42D2E; Wed, 13 Mar 2024 13:09:12 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2057.outbound.protection.outlook.com [40.107.243.57]) by mails.dpdk.org (Postfix) with ESMTP id 5200E402B8; Wed, 13 Mar 2024 13:09:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mX7L6mTnMj7OojTcxcJPJIruQJ43HvTUfR2JCNacI9OPOQ/Nmrm5VQivP5Sto3S1KFhm1V4a8jwDx/yHBdYnylD/cbTyAX4OapMjXtkkh5AnZ6qOPxIlyvk1+Tf22V7M3HyAYd7lMur/cV8wqVe4N6qzFpP9BaseIEmWnbZLsspGS5/C6ylSX8+wtA+oAFwk0H3oGExLr4tQ4eDoVRlsQcQ+WzOR46y16ip9gPcpuNm2ekcho4qyLhYvWPeeNXRoNKOENoFSgvZGSXM70hLAVB26ScZyCnimYemksStvOo3YyJCdBSSwds7FbvZ2zhc9bf5eXQByzoJYOTAnKtXCNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v69xpu/pUjm4FPjPCG29Uwed4E74HuB31bQcv4Y3nKw=; b=TH/vOEjIERqbzlqXOMIOlihEMewb6cKQqHZhk1BUZTXZt5b7W2MQ/hqy9gWmmkAr2cqhUh6f6HHb9uqLYsPutwPykIczrmlHDF5OeaQvF5FHLvX+Xmfmh7iPj7A6csV0B8xd8eHlsY7DX9MEnOoNNwyjzn01trx2jWAgNeU44rkWULpa1kLeuWigtsyhPxfQvxyAXt//UwRlzZ8BJXPqegXksQ5L6yVA0PL6rgjFT5SbeKpSIpDqfOHn93Z2C2MLVOh5Ne7JOPqq4dQuTXLm3ws9p1G701Pz0qz4MFU+iO4bBDerjCqHC3Rk3VzxK2YVvhdIlltS3aQy4fHl1ShMpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v69xpu/pUjm4FPjPCG29Uwed4E74HuB31bQcv4Y3nKw=; b=q06iN/2A+L4O4o+4WZoYnnq16OyrokvlbO3XbsawyhZspymiMDVk4ufs27ooV1VBlSMXNXRbEtrzif+8rkybi/bBOyWhaqP9Uf30Y8neRc0fVoF5bRQalqd6GmheECi2/DWBFro25lsT4pzsGaFls+8efw+CuRM+ksucYhriNJQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB6780.namprd12.prod.outlook.com (2603:10b6:303:20e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Wed, 13 Mar 2024 12:09:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 12:09:05 +0000 Message-ID: <18743010-a6ae-43c0-9a39-a2a9a6b56e4b@amd.com> Date: Wed, 13 Mar 2024 12:09:01 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] app/testpmd: fix burst option parsing Content-Language: en-US To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Aman Singh , Yuying Zhang , Ivan Ilchenko , Andrew Rybchenko , Bernard Iremonger References: <20240308144841.3615262-1-david.marchand@redhat.com> <20240308144841.3615262-3-david.marchand@redhat.com> <92e9792e-9054-4c8e-a409-739176707175@amd.com> <70c06f94-bba1-48f3-8c59-9e523ff0498d@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB7PR03CA0074.eurprd03.prod.outlook.com (2603:10a6:10:72::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB6780:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d8c4489-84b1-47ae-7128-08dc43566103 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qWKCKH/3pbaXwT8B9je8BEn5YeecEReo1GBHVOF6CrI6lOIPXk/LInlvOFG1l88pqB1BcBp+l8Tt6YjsWY0NJeBd3Ac1vDqcEjOYwikb0qKSAQul4fOpC8DE26mFc9w7xULU/xuuu+f5qZ9guHUum91RSC5EmDlHPMF1vh2OxA9IIHn75j0zyNScDUvO2AcfI3H4WmD/rnqop1BU7rH/ITZqnhiuUUn3NtOTqz/D0hnBaFs/R9zCNnhbv8UTCV3HkNAT/2+xYyTKPH+5wn/nGvmJzcsgEh7YBCBVp/q3ylK3J6+Lqbh3cs6Z3/2ZzMiAfxHqePuy/JX99KgJwTsG1R8rTtTiQ5uzobt+J2Rv2wWnF/YBWgUrSLT032rei8h70fJ/VtZcEVZxh4V9U82NyaQjpS1d3WASecbIVFVmOUCl2GqB259P8+QUwwFj597HEZ4lYhvbA0b1qG/X5HM1VKzAoUpXKHp6WUVFIG38rZkqG8mSq03EAN/kkggG/7c27/QYKXUfbvQgxVdzrC8PNqugw1EHR4vGhhya7yjvLmkVdHbQLtkuCxxlppadIY4lBSWxOEnQFv2A8odVMi0iW2WOgfZYaKtt13KMn3rTxplV5vAfociQESpp45eJG4uMFhDcTzqUPnfNeerHBwf6zfchVr8RC1gA57v9kmqtEzs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkNpNWI3WXMzemJzRUY1cU85aEdhRVBIcm42N3F1NVUvNmFFb3dIMWt0b2cr?= =?utf-8?B?R3kwSHhOUGRMM2VPRDhyQWIzWHh4a1RjVGRUVXk3NVBjcHpCcm0rd1A1QkNu?= =?utf-8?B?Ukx0V3BTdkQvWjMxUW4wdGNDYnpHZmpzdUI3WjlXV28za2pYNDVsSTg4anIv?= =?utf-8?B?YjQ0aVNCeEprWkFFejFrN2NpYlNwMU9LcUo3Q2NYRkxKb1hDYkVNUERQZEll?= =?utf-8?B?ZTlrWXRocU1IaE5rN2dPcnhVemtTYytOZU5LR1MyVVFZcFd3dFhQZ3ZMcmFQ?= =?utf-8?B?c0pFeDZ0NldtWmJYRS9UVmNtQ3hRdW9sOThwWU91OWVVdTRtQ0NmL1R0TlBT?= =?utf-8?B?UUFPVDFUQXNuc1dQR2FNaHkvU3FucFllSVlrR3B1enFLeDE4eGkrRFFoRGlQ?= =?utf-8?B?Wm9rajFrWXUzZ2ZGTjBnd3pYSXc1SWxBOW9DMXpvRWZMUWtwd1dURlh3K1N6?= =?utf-8?B?U2dzak9DZkVMZHM5enBvQ0NZVVlWVXcvQU8zNTA1cjE5WFZyWVE5ZTNBOHJp?= =?utf-8?B?WFptVFRrS3lsVnh2R2RXcFMwMks3bzFPa1FBT3ZndzZkeHFpL1lJNS9qRTRq?= =?utf-8?B?bGFCTU1yVTlvd3RobnU0akhkRGlHcklQRm01MkRzMlJpNzRsUGszVVRqYUxl?= =?utf-8?B?ejRIWUxhOURBbE1RYiswZ1VGdTdBZXFGcExKa1p3SEhtUXM3cDdPYm4wR3VJ?= =?utf-8?B?WEpZdTlQcDZwZmdRbWIwNWwwcFdIWXVhZ29ndzJFdmhlKzcwRE5EcGNqUmxs?= =?utf-8?B?T1V3RDIrYzEzSDlPVldzcFZiWEpDcEc1TnRWbEdDek01bzhpdXJCOTlWbS9V?= =?utf-8?B?TDZlcWZaLzcwZGNMc1FjbE16RTZIdVFkYjVscXdrRG5lc1pEd3NPT2tVMXFF?= =?utf-8?B?VmJwbDgrRzRpbUVnckp0Q2RGYld2aTluZEY3eWJsV1l2NE95RlFWcUNqVlhT?= =?utf-8?B?NzVvZ2dxSVYyUFlzVkNHSjRIV2hKZWhaeGdWWnVzUkczTTZWZ0lVcnZXVDhB?= =?utf-8?B?eXhEM0pQVXhGNURYSk5VSHF1K29hVFRFMXA4MXMxL2dPVy9GNjNCRERXVzBo?= =?utf-8?B?WFYxSFkxaUx0bkJiYUVJTlNqLzdXL0lkZEpZM1RmbCtJbEYzaHZYVmF1eC9r?= =?utf-8?B?Tzh2MnVnQjZaQVpqOExkUTgzZGcxOTlMcysyTFZESEgzNDFCWXhwanJobVQy?= =?utf-8?B?WUgxWEsrM1dOelVWTjNBaHZzNXJjT1cra3c0NlltNEdTd3FXTEZ0aDFCY3hL?= =?utf-8?B?citLOVJ2d3hheVp0T2tPU0h5V0F6ZnpId0xaQzZHOXdaVWIvdmQzMFJLQk9o?= =?utf-8?B?TzI0Wk1KMElXZ0pLTUJGeCsyYlovbDBqOEtsNkpwRWYycy9OKzMwOFVNVzVX?= =?utf-8?B?RmRDRmttd2hKS1kydCtiQ3ZzemM0SEdxTjNKODJiRURYQUlEZUQwYk1OQ0c5?= =?utf-8?B?NGlmU2hDUXo4bTV4RTJFS3FYR0xzdUZlOTA2cFo0SDR0QW8vVDBxNTRYRW1n?= =?utf-8?B?ZURrYmZYSklBNVNsK0VjbWM4TlhmMUd4SXVuaEI0ek93UmFnRG9HMnBqR1BR?= =?utf-8?B?NDNZWWdQNG1XR1JNVXAxWWg3bHF3YnZNblo4SW5RdjZETzJvOFhWOW5TQTY1?= =?utf-8?B?RmRTSVZZMmxQUlBQYm8xT3JtZ1REK1JWeVA4c2FqOHJyRUVGQys4a0JvMGFo?= =?utf-8?B?ZW1JdXVlNTU4MU5kaHVaSmh1ZEZ3YS95RFFSdkxRY0hvU05sS0FiODZJdUU4?= =?utf-8?B?NGlDVzhoQmtuNXUzbkVjWVZJOEJ2eWhYbnJQcTJIVWpCbDQ3ZkV6L05RdXpm?= =?utf-8?B?MnBCR0s3bllXMDNHQnc5eVp6MDZVQ1lYZE5uRVowelNxY3lqSHVqaDdLQW5k?= =?utf-8?B?Q0YzZ1JsNFl1TXBWdlZoaHBHWEJtVUxZeVF3aXc3dVh0Z0huT1pUaVdOUTVx?= =?utf-8?B?R2ZPTVZqbVhEZ1B5NjVKN0VDQW85Z0I5UTE5b2doMGJYaTdFa25yMG9xMTBw?= =?utf-8?B?R0tmSnhPSGZsVkxEZmwzVVN4dW9rZ0UzaHRTeHI0dWlpemo3V24zUnIwS1VY?= =?utf-8?B?VXZYTlJPZUhLZGJLMDVNbEkwWllYZmlwY0JrUkhLZGRMTTJ2WnZVd1NkSFB0?= =?utf-8?Q?FmfGj9KTP0QJ4E2bly7MfsoYS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d8c4489-84b1-47ae-7128-08dc43566103 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 12:09:05.5443 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0HLw/mbXDBXPxzO4y1C1kW1v9luOX8KKoz8RKRSpTA9H8SUuKZZ3G8oGB973Vn+E X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6780 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 3/13/2024 11:13 AM, David Marchand wrote: > On Wed, Mar 13, 2024 at 11:37 AM Ferruh Yigit wrote: >> >> On 3/13/2024 7:24 AM, David Marchand wrote: >>> On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: >>>> >>>> On 3/8/2024 2:48 PM, David Marchand wrote: >>>>> rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but >>>>> for the theoretical case when it would fail, raise an error rather than >>>>> skip subsequent options. >>>>> >>>>> Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: David Marchand >>>>> --- >>>>> app/test-pmd/parameters.c | 6 +++--- >>>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >>>>> index d715750bb8..8c21744009 100644 >>>>> --- a/app/test-pmd/parameters.c >>>>> +++ b/app/test-pmd/parameters.c >>>>> @@ -1128,9 +1128,9 @@ launch_args_parse(int argc, char** argv) >>>>> 0, >>>>> &dev_info); >>>>> if (ret != 0) >>>>> - return; >>>>> - >>>>> - rec_nb_pkts = dev_info >>>>> + rec_nb_pkts = 0; >>>>> + else >>>>> + rec_nb_pkts = dev_info >>>>> .default_rxportconf.burst_size; >>>>> >>>>> if (rec_nb_pkts == 0) >>>> >>>> 'eth_dev_info_get_print_err()' already fail, but it may not be very >>>> clear to the user, >>>> OK to print a failure log, but setting 'rec_nb_pkts = 0;' as above also >>>> will generate an error message that also may be confusing to the user. >>>> >>>> What about print an explicit error message for the >>>> 'eth_dev_info_get_print_err()' failed case? >>> >>> rte_exit(EXIT_FAILURE, "Failed to retrieve device info, this is >>> probably a driver bug. " >>> "To workaround this issue, please provide a value between 1 >>> and %d\n", MAX_PKT_BURST); >>> >>> Does it work for you? >>> >>> >> >> 'eth_dev_info_get_print_err()' already logs error about getting device >> info, but driver recommended 'burst' setting failed information is missing. >> >> What about more direct, >> "Failed to get driver recommended burst size, please provide a value >> between 1 and MAX_PKT_BURST" > > Which is really close to the existing log message. > > if (rec_nb_pkts == 0) > rte_exit(EXIT_FAILURE, > "PMD does not > recommend a burst size. " > "Provided > value must be between " > "1 and %d\n", > MAX_PKT_BURST); > > I am unconvinced, but if you think strongly for this, I won't debate more. > > Yes it is close, and I don't have strong opinion on this, But existing message says "PMD does not recommend a burst size.", I think this may be confusing for user. If I see that message I would either debug relevant driver code or communicate with driver maintainer for it. But that is not the case, just failed to get recommended burst size and problem is in testpmd. Anyway, my concern is existing message can be misleading for user.