* [dpdk-stable] [PATCH] app/testpmd: fix Tx metadata show command
@ 2019-01-22 15:16 Dekel Peled
2019-01-23 15:08 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Dekel Peled @ 2019-01-22 15:16 UTC (permalink / raw)
To: wenzhuo.lu, jingjing.wu, bernard.iremonger
Cc: shahafs, dev, orika, dekelp, stable
Function cmd_config_tx_metadata_specific_parsed() takes input value,
applies rte_cpu_to_be_32() on it, and stores it for Tx use.
Function cmd_show_tx_metadata_parsed() displays the stored value as is.
This patch modifies function cmd_show_tx_metadata_parsed(), to apply
rte_be_to_cpu_32() on the stored value before displaying it.
Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item")
Cc: dekelp@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 3ddc3e0..51704b5 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -18455,7 +18455,7 @@ struct cmd_show_tx_metadata_result {
}
if (!strcmp(res->cmd_keyword, "tx_metadata")) {
printf("Port %u tx_metadata: %u\n", res->cmd_pid,
- ports[res->cmd_pid].tx_metadata);
+ rte_be_to_cpu_32(ports[res->cmd_pid].tx_metadata));
}
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-stable] [PATCH] app/testpmd: fix Tx metadata show command
2019-01-22 15:16 [dpdk-stable] [PATCH] app/testpmd: fix Tx metadata show command Dekel Peled
@ 2019-01-23 15:08 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2019-01-23 15:08 UTC (permalink / raw)
To: Dekel Peled, wenzhuo.lu, jingjing.wu, bernard.iremonger
Cc: shahafs, dev, orika, stable
On 1/22/2019 3:16 PM, Dekel Peled wrote:
> Function cmd_config_tx_metadata_specific_parsed() takes input value,
> applies rte_cpu_to_be_32() on it, and stores it for Tx use.
> Function cmd_show_tx_metadata_parsed() displays the stored value as is.
>
> This patch modifies function cmd_show_tx_metadata_parsed(), to apply
> rte_be_to_cpu_32() on the stored value before displaying it.
>
> Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item")
> Cc: dekelp@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-23 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 15:16 [dpdk-stable] [PATCH] app/testpmd: fix Tx metadata show command Dekel Peled
2019-01-23 15:08 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).