From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B665D42B34 for ; Thu, 18 May 2023 18:25:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97B4742BAC; Thu, 18 May 2023 18:25:52 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by mails.dpdk.org (Postfix) with ESMTP id 15F1040A8A; Thu, 18 May 2023 18:25:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O4EtI9kPVCI5ZWfIbCpfPi+GRD0FtXvOEpmNldyqoEYQbiLXGm/r+XH2SyF5b6eMrnt7Qg6CFY6yOVAMOvr/HHDjQtFEXNMDAIctsqK+Q93CPRrxZT9fRvl69aV1pkT/2IGb+qtav23jf+oOAStIeBJSX2fmwx9Lp4ZDbrBBkHH3EPG1qfNqEDSrEanEqTU7KLpLg2hRbhw+sCO5/OJ8dQnPlpTGBtU1DA7LWJk2afKgNYXyX1wAttHgoSP3gOAVQMvKCdahfvNQnjV0R0KVqSxc+J9D91zLbpw7Jpt8yiQDppGqug5e72PczZZ0Ak2HAAWs63FIvtWPC2Pc6jYcNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZL0lkyV9zbP6roGytiVbIb6DgEU252Z6pRqrOTraqYA=; b=YBjIL279GIWXihlUspEXFvH6+/Xn/QU42CvmChttB+CEtCgy7CwTs9yG579835Em0YpSorPpOdC/hdXY079NHGsaEYjTwYRTjMlV4fXgzOjhm/HU/U3iV/vAfcXj8SeY5vmVAeegXYB/36qVtDQWvbkH4CWM2GMgu9c6LkC5Q163j3Fmeyo+N4ELVMFAzuBd+MLw3wnzIryaXxXxk/1dH+kxJ7wXiY2vlclT90KFoXbALBNgOKTpAmleGpvwHSX1qn7m4Ip+xuHICyEoz2d0r110leANXhUEkH1n8uaTceX22XVPzeUQKPe8zQqTzN3mWVyumAC+65JiJVmC+2RrSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZL0lkyV9zbP6roGytiVbIb6DgEU252Z6pRqrOTraqYA=; b=Ah8I28Ydbo0AWy73atJhnXg/sUov7nS/A5gdkP8lKrZWsNsY663V45sB7PdX17U096nTKANFaAro78ZQGEEpnINR0/PqhTJzf8JboQyV2SO14RKvV5iwzkOGlBVefxx7pDtASqd8KqjF8d8Os/knhvRfuqXX/uVy1oR0A4Y7MyM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ2PR12MB7944.namprd12.prod.outlook.com (2603:10b6:a03:4c5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Thu, 18 May 2023 16:25:47 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Thu, 18 May 2023 16:25:47 +0000 Message-ID: <18f3e3aa-1fc1-24a8-50c5-90e45e9cd688@amd.com> Date: Thu, 18 May 2023 17:25:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs Content-Language: en-US To: Ivan Malov , dev@dpdk.org Cc: Andrew Rybchenko , stable@dpdk.org, Andy Moreton , Denis Pryazhennikov References: <20230424143046.6487-1-ivan.malov@arknetworks.am> From: Ferruh Yigit In-Reply-To: <20230424143046.6487-1-ivan.malov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0529.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ2PR12MB7944:EE_ X-MS-Office365-Filtering-Correlation-Id: 5854ad78-b2f2-4c14-e7a0-08db57bc88c6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SZaDDb/HAUKOnHiOEjbkqxtooOZ2snV5C98WVL36a32stAFssAPgD7cIu4BeUq6pbJpEE3v/avtdIwih/FevLSHoe+yeGlBGU7t9A2zKFN/O1lqqwxfWjg/DI9xKomuoXrgFwhlrpms2/+mgF5KGcmbftYS9eP0LdLD6ePasD872+Zo18edZueXH93MUL5mJdDqKJf90rjCKNKZu8S3dEarQZGSdkE7ujv8EWbj68PsS+sSir+PXdkc4k2N1V+NcdSQkG5VaMxGp5Q4zA0iCmM70zYYRiN7Tfrk7sYQKB0Vv2SwJLK4jild+HGe/B0cZkokuH4DTkMLv0uPHZ5u4SXzdMYiKG0zAWC74ADKcPcGtfCI2Ofch64AqSLm2qBisZvxSswE/dhBPczZVOONQcBbk6tpLdzofnl6jHX2rwxU53kQH/5hBFU5E4K+fWvrx34L3gAh/IcuqUcTHL8kZtFRRHXM5i1rdW726C6wvRigVGvfTjNY2JSzrcuUnRIrShLif7VpyS3RLWKoQrsCninrYJoipmrBz7uRpdwp+isuDQrxzEm2YBM9vsoglpAfPRWifOTOfd1d5idy7nFSTavoCjmz59bhsgSSYSPVP/IS1AyPJmCvaOPrEoD65r6pSkiKl/oLMRkI1wCv2Mx1hdw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(451199021)(5660300002)(41300700001)(2906002)(2616005)(83380400001)(36756003)(31696002)(86362001)(38100700002)(26005)(186003)(44832011)(8936002)(6512007)(8676002)(6506007)(53546011)(66476007)(31686004)(66556008)(66946007)(6486002)(6666004)(478600001)(4326008)(54906003)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0F0SUZ2UGlRZTQ1Qyt4SGdRR0tFSnM2WE5EMnBGQi9xbTE0UWovOVMxK0d0?= =?utf-8?B?NUNCaXVndkduQWFHY3ZyMTZTSnduVDR2K3hkMzBGWDdySzMycW9ReGMveDdD?= =?utf-8?B?RWxLcEp5ZFA2SlM0azVkSFdVRzRDQ3FRVGFRVnc4RFNQT2o0MGdZdEEzSlhx?= =?utf-8?B?REwyUzRhMTNFZHE2M2k1cE5icWlhY1Q3UWhjS1B4TlBhT0hTOSs1N0hiVW5z?= =?utf-8?B?KzRCM3hrVEtyOHBONm5Pc0h4SG9LVm1kSHMvdk1EU0F0SENiNXJwak1kMFdJ?= =?utf-8?B?VUEyWFVPZmRmSm93eTFEODhGdXc0SzYrWnhpdjNNR3ZUNjdMbXBXenpnRjlT?= =?utf-8?B?WmtMZG1EVFI2T0NLSlJHV1VucTk2VEczSjk3VW1kYi92cnFxay8yWk1FL1pB?= =?utf-8?B?Q2hUSkFxdTZSRFBrUGdXUkpnbzBVb2FGWkJuMlA0Z3o2bkx0U1F3WFRnTERt?= =?utf-8?B?eHdSOHduZngrc1ZpTXE5ODZOVENUUXU4Rk1LWXpTb20zazloa0pjbkdMYUU4?= =?utf-8?B?QWtEZTd4eC95ZDFXbXhmZHlzYVZpTkE1WTRCVHRrRWx1enAvUXdWOWhuakVr?= =?utf-8?B?UWJ4WWs2ZEhPSzZ0enhXUnZSa1hYZ0F0YTRXQ3o3L2Zod3dZcnpUOHRHS2Vs?= =?utf-8?B?RDdiTU9iZzllOUFRV1p3RERRdDBFOCt3TUcrdE43RVhwdnB1a3VWV24wVjlz?= =?utf-8?B?VElTYlBnZkFnL09iL1ROVHQrQlBVZXJqSFpBU1phcDREM1htNGxiUEl2MXh3?= =?utf-8?B?dFFvemdtazJhMUt4RDlxUi9FWlhiTFZXL2QvYWZXQnhjQnZxS1NUT25abnRS?= =?utf-8?B?cnRuc2dmdkhIbCtBRnRGM2ZiMUNZb1hBbDl5ZzRmZS8vQ1BTb2t6YUp1Z1lH?= =?utf-8?B?L3c0RzVuUzdKL25FeXJ0UmNqckJ0K0J6U0FaYWttM3FReEt0VUMvc3NWRHV3?= =?utf-8?B?Z2M2bTI0aDNGclM2WVd1R2srNS9JVXlxUzgzSUhmUU5Fb2RlTG4zbk5DUjg3?= =?utf-8?B?MS9WWE11VTNyczRNY1ZjWFU5S09rQ01JTlZZYm54WWkxN2tzUm4xZ2dNRkJq?= =?utf-8?B?dG1EZzc4QTdKeXNHNExYZTFqb3N0SG9ySVQ1Q0pwWDVySkhtOUMxRnEyMHVa?= =?utf-8?B?RU9RQlFDejBrY043Ti9rKzBGcVpwczIxcXd3Zm0veHhBSjZwSERQZHI3ellR?= =?utf-8?B?elJPTm1QS3hyNEp4WmlBUUxzK1VBcXo5Q3NLcGpQbU5EM3d1S2pMNmx4MVRY?= =?utf-8?B?NzM2K3hKWVdraUlVSjRwd0ZLNnd0UjQ2dWIxeHAxdlhaN2IwNmJ1VzZVQzVI?= =?utf-8?B?S3dNNjJ4bTExSENMUjBPTVhwVUhUK3RjZ3RaQ2F3c0ZIdUswMk4zeG45UWk4?= =?utf-8?B?aVkvSTcwSUtRYUtudFhrVjBOUTdkZjNCeUpnRkJ5cHJTTEFra2lHUDVZZ3o3?= =?utf-8?B?aHROcml6aHBwWnJ4RmF4VXZmdDUxSENNRkNTdzNxdWMvcHl0eDR6TE11T1RM?= =?utf-8?B?bVJDMXFpT2RSWGpsQkpyNXVGaEJKLzMrd0tCaFpVUnI1SW9nUFpjTi9wTWdN?= =?utf-8?B?dGEvMk95cFlOL0RaNzAvb0RPQnVwVzR3NzA3UDQrQzhsRy9VeXp6YWx2ZzBC?= =?utf-8?B?TDVFdHh6b2xsa2VQbGhDSmIvQ2tGZkc2bW1oUEhaenpaR29tZVJBdFRuZ2k1?= =?utf-8?B?b05PZ2xCOXlMZkpFelFCaGUxR3QzZ2JSTkZ6R1Rrc0MzQWhGR0wxVnVGM0d0?= =?utf-8?B?eUtJR0c4amovVU0vOXVhbXQydmwvWGt6WUdveWVvNGZtMjJIVzBPOUxOaUdK?= =?utf-8?B?RXVONUlGR3JuN0RuMnRhK3RaUE9zMXdScXlvNGV6NzRCMmtzcHhYZ3d1bUZm?= =?utf-8?B?dHQxQmxOWWd0Tjk4NXRsbmxXdTVpN1NBZzBHS2dsTllhOUJtWFpNazdiK3VD?= =?utf-8?B?a2pwOEhQbnBMYzhpY0QvZzVsUFBQVlBKK1BacHArdzZOVkNkaUFXWk9HcU1q?= =?utf-8?B?ejdxOGJqS0hrYVJXanBySitBQ3FBRGNGZzBKYlV4dHUwK0I0UnhLNEhhWTlX?= =?utf-8?B?YlFtMVJhYXRVN1k3eVVuK1dKWmpKRTROcS9STFlxWER2ZWhINElUcnlUL1BT?= =?utf-8?Q?n1/+AKcradnHIrOGnXiw0ICn0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5854ad78-b2f2-4c14-e7a0-08db57bc88c6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 16:25:47.0767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rb2EXvZyIeDmjqGWfES0ZH767Ph02xsdyFVjNOhjDNrYVvjhXHQ1+X6qUEbDD4S9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7944 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 4/24/2023 3:30 PM, Ivan Malov wrote: > When the client driver (the DPDK one, for instance) parses user flow > actions, it ends up with an action set specification. Next, in case > there are any FW resource-backed actions, like COUNT or SET_DST_MAC, > the driver allocates these resources and indicates their IDs in the > action set specification. The API used to set these IDs checks that > the current value of the target ID is INVALID, prior to the call. > > The latter check, however, prevents the driver from updating the > IDs on port restart. When the port goes down, the driver frees > the resources. When the port goes up, the driver reallocates > them, tries to set the IDs in the specification and fails. > > In order to address the problem, add an API to drop the > current resource IDs in the actions set specification. > > Fixes: 3907defa5bf0 ("common/sfc_efx/base: support adding encap action to a set") > Cc: stable@dpdk.org> Hi Ivan, As far as I understand this patch extracts some code into a function, so I expect no functional change in this patch. So not clear what this patch is fixing? And I can see this new API is used in next patch and it fixes an issue. But while backporting this fix to LTS we want both patch to backport because there is a dependency. If there is no functional change in this patch, what about merging these two patches, and explain what is fixed? This also helps backporting.