From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ali Alnubani <alialnu@mellanox.com>, dev@dpdk.org
Cc: motih@mellanox.com, stable@dpdk.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix 32-bit build
Date: Thu, 27 Jun 2019 17:01:51 +0100 [thread overview]
Message-ID: <1937b4f1-6ec3-2f68-e3cb-fe80417c27c3@intel.com> (raw)
In-Reply-To: <20190627151007.5156-1-alialnu@mellanox.com>
On 6/27/2019 4:10 PM, Ali Alnubani wrote:
> This is to fix the error:
> ```
> drivers/net/mlx5/mlx5_defs.h:14:26: error: format '%lx' expects argument
> of type 'long unsigned int', but argument 5 has type 'off_t {aka long
> long int}' [-Werror=format=]
> #define MLX5_DRIVER_NAME "net_mlx5"
> ^
> RTE_SDK/i686-native-linuxapp-gcc/include/rte_common.h:642:27:
> note: in definition of macro 'RTE_FMT'
> #define RTE_FMT(fmt, ...) fmt "%.0s", __VA_ARGS__ ""
> ^~~
> RTE_SDK/drivers/net/mlx5/mlx5_utils.h:79:11: note: in expansion
> of macro 'MLX5_DRIVER_NAME'
> RTE_FMT(MLX5_DRIVER_NAME ": " \
> ^~~~~~~~~~~~~~~~
> RTE_SDK/drivers/net/mlx5/mlx5_utils.h:101:2: note: in expansion
> of macro 'PMD_DRV_LOG___'
> PMD_DRV_LOG___(level, __VA_ARGS__)
> ^~~~~~~~~~~~~~
> RTE_SDK/drivers/net/mlx5/mlx5_utils.h:103:2: note: in expansion
> of macro 'PMD_DRV_LOG__'
> PMD_DRV_LOG__(level, s "\n", __VA_ARGS__)
> ^~~~~~~~~~~~~
> RTE_SDK/drivers/net/mlx5/mlx5_utils.h:109:2: note: in expansion
> of macro 'PMD_DRV_LOG_'
> PMD_DRV_LOG_(level, \
> ^~~~~~~~~~~~
> RTE_SDK/drivers/net/mlx5/mlx5_txq.c:569:3: note: in expansion of
> macro 'DRV_LOG'
> DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx",
> ^~~~~~~
> RTE_SDK/drivers/net/mlx5/mlx5_txq.c:569:48: note: format string
> is defined here
> DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx"
> ~~^
> %llx
> ```
> Which reproduces with gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0.
>
> Fixes: 6bf10ab69be0 ("net/mlx5: support 32-bit systems")
> Cc: motih@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
(empty string at the end removed while merging)
prev parent reply other threads:[~2019-06-27 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 15:10 Ali Alnubani
2019-06-27 15:26 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2019-06-27 16:01 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1937b4f1-6ec3-2f68-e3cb-fe80417c27c3@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=motih@mellanox.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).