From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 753F6A054F
	for <public@inbox.dpdk.org>; Mon, 15 Mar 2021 23:24:27 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 68C4B2426DD;
	Mon, 15 Mar 2021 23:24:27 +0100 (CET)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 449C74068B;
 Mon, 15 Mar 2021 23:24:25 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.nyi.internal (Postfix) with ESMTP id 673475C01A4;
 Mon, 15 Mar 2021 18:24:23 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Mon, 15 Mar 2021 18:24:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 W9d9MCwfkWos+CIqc1KRhzSh+b0isQuMyScw3efHYy8=; b=q7PaUIKX/XoLVtrj
 JuKkoLprsWiJST42OEfarbQXALDaAlFGTNRntfWoFbLh0g4c6u5U8ByQULp6HJcl
 14W1O8DHZ/afNcNg43ng3A9i+jXZdw4mOMbKlD3G7f0FlJhm/el1ao+NgbrC4cxz
 aRQbPBu6iME8Fe0PaZMpNqGbVserrGl+DuFZ2lS7JsrP33ILjzUfgIwDfdtVrwql
 sk2epBDXNbaJ8qwnz6i159/6OTr2ESEiSa7hszZzWr6y98Jv+3NIDEg2UvO3xSdJ
 XqDzD04/tbJYMe98/5Ku5bXbHMamaEOchivVSEHRCpn6+gJqqJsNf6O86YetTH7v
 CnQbTA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=W9d9MCwfkWos+CIqc1KRhzSh+b0isQuMyScw3efHY
 y8=; b=rSH10KsEV8UjM9JN8iNr5McIaEHcyVxRjWVnD99npQBDF2PVPFKQTv8x+
 WpIa+gNWcizn3Il2sU4lLiARH0VGbhBW4OetXH/eortRwS1weaNVXl8wDnqO7eB8
 HMhf5g2wONvxvJZGZBOSX55FFYhCQTJJpYplPr7y5m5KgCvmky7YveVqaKXmWRxS
 cTg4OEzAXu8pjakEzaj+D2px7Fy/CqoIOMt7PA6UXSqz3Yo5V237Ivkjk8cdGgc8
 Lx/ZVwchax3umWT1oJwHN2C9yknPKS0VUyWqgazwV89THc306vIw3fkDXutNSqtK
 YYsrpoIvj8hLfHDJwZjmaHf3l0LJg==
X-ME-Sender: <xms:lt5PYP669un3yQ0qQu3ibEKVD2d_iYuOBNC9mW7lhPHRuxl9mxOPkw>
 <xme:lt5PYE7uKzhC61RC7qKBFne3teMSc5EIFIFSGhSma69v_DVQbBsrZl8RmV6S95z8T
 KNd39Mrk2Tw8yMf0A>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeftddguddtucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:lt5PYGfjFq7Gm71fWS9uiCyjbroQ39OUUa1nwk3_kK7QVRaDOJGZUw>
 <xmx:lt5PYALJ5OlEI47RjA9UOlU8akFN8wP8pZRQFI_G-YKAfw6_C8WcwQ>
 <xmx:lt5PYDImHWkgUvVJW-2dlq4T4bfLEdSdJayAX8n04NWaQtegEoo47g>
 <xmx:l95PYL2IfJkqBZTCtzQBtWWcDh2qWHxhtZVH-a0iF5zB35oI45G0lA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id A43C41080054;
 Mon, 15 Mar 2021 18:24:21 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, mdr@ashroe.eu,
 kevin.laatz@intel.com, stable@dpdk.org
Date: Mon, 15 Mar 2021 23:24:20 +0100
Message-ID: <1962071.jRph8S4ArN@thomas>
In-Reply-To: <20210216151329.290332-1-bruce.richardson@intel.com>
References: <20210205193933.410011-1-bruce.richardson@intel.com>
 <20210216151329.290332-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] eal: fix querying DPDK
 version at runtime
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

16/02/2021 16:13, Bruce Richardson:
> For using a DPDK application, such as OVS, which is dynamically linked, the
> DPDK version in use should always report the actual version, not the
> version used at build time. This incorrect behaviour can be seen by
> building OVS against one version of DPDK and running it against a later
> one. Using "ovs-vsctl list Open_vSwitch" to query basic info, the
> dpdk_version returned will be the build version not the currently running
> one - which can be verified using the DPDK telemetry library client.
> 
>   $ sudo ovs-vsctl list Open_vSwitch | grep dpdk_version
>   dpdk_version        : "DPDK 20.11.0-rc4"
> 
>   $ echo quit | sudo dpdk-telemetry.py
>   Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2
>   {"version": "DPDK 21.02.0-rc2", "pid": 405659, "max_output_len": 16384}
>   -->
> 
> To fix this, we need to convert the rte_version() function, and any other
> necessary parts of the rte_version.h, to be actual functions in EAL, not
> just inlines/macros. The only complication in doing so is that telemetry
> library cannot call rte_version() directly, and instead needs the version
> string passed in on init.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2:
> 	rebased on top of main for 21.05 consideration.

Applied, thanks