From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 548082B9C; Mon, 25 Feb 2019 08:50:40 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 6A93280005E; Mon, 25 Feb 2019 07:50:38 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 25 Feb 2019 07:50:32 +0000 To: Thomas Monjalon , CC: Raslan Darawsheh , References: <20190221190125.24140-1-thomas@monjalon.net> <20190221190125.24140-3-thomas@monjalon.net> From: Andrew Rybchenko Message-ID: <19f468b3-9c2b-af91-58a5-5a23b5744a88@solarflare.com> Date: Mon, 25 Feb 2019 10:50:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190221190125.24140-3-thomas@monjalon.net> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24452.000 X-TM-AS-Result: No-7.170900-8.000000-10 X-TMASE-MatchedRID: oTBA/+sdKaYOwH4pD14DsPHkpkyUphL9HUEsjxm+pghaW2Ktn+I8/vcB Lyb5pFK2hcQa8fmvdHnNe0fPRIWv1WKztShDQzFuFYJUGv4DL3xflOpBqBHTt0njAvvhWuZY807 t+VEWpeYgZIcq73TEpZJTzjwz+Gzox7hajJv6RUXIOn6NK8S1ayXdp9l6EkRZ52VTYrkmb1uCAE CxRbm5ZM4ffyU1s6hMXEjZllf2bhffX2sZfyOJoZ4CIKY/Hg3AtOt1ofVlaoJlgn288nW9IHzRz XQdd7Y5joczmuoPCq0Vf3X5ZQ9iIQj6wtbIDH/sTqhmQ1qVSFgLLjTtX3cnYklMOqKofLV7Vc3a ovCifu8IuxDk83JHIoOP5SyT3zQXLOLldxJzdbs+kK598Yf3Mg== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.170900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24452.000 X-MDID: 1551081039-JxAkOrvUaGfJ Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] bus/vdev: fix hotplug twice X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 07:50:40 -0000 On 2/21/19 10:01 PM, Thomas Monjalon wrote: > From: Raslan Darawsheh > > In case vdev was already probed, it shouldn't be probed again, > and it should return -EEXIST as error. > There are some checks in vdev_probe() and insert_vdev(), > but a check was missing in vdev_plug(). > The check is moved in vdev_probe_all_drivers() which is called > in all code paths. > > Fixes: e9d159c3d534 ("eal: allow probing a device again") > Cc: stable@dpdk.org > > Signed-off-by: Raslan Darawsheh > Signed-off-by: Thomas Monjalon > Reviewed-by: Andrew Rybchenko