* [dpdk-stable] [dpdk-dev] [PATCH v2] meson: remove build warnings
[not found] <20190318162804.28974-1-jerinj@marvell.com>
@ 2019-03-19 17:22 ` Jerin Jacob Kollanukkaran
2019-03-19 17:36 ` Luca Boccassi
0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-19 17:22 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, bruce.richardson, bluca, Jerin Jacob Kollanukkaran, stable
From: Jerin Jacob <jerinj@marvell.com>
Remove the following warning by comparing string to string.
config/arm/meson.build:153: WARNING: Trying to compare values of
different types (list, str) using ==.
Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for ARM")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v2: Remove meson version related warning as bumbing the version needs
techboard approval.
---
config/arm/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 8e892fa77..170a4981a 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -116,8 +116,8 @@ else
cmd_output = cmd.stdout().to_lower().strip().split(' ')
endif
# Set to generic if variable is not found
- machine = get_variable('impl_' + cmd_output[0], 'generic')
- if machine == 'generic'
+ machine = get_variable('impl_' + cmd_output[0], ['generic'])
+ if machine[0] == 'generic'
machine = impl_generic
cmd_output = cmd_generic
endif
--
2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] meson: remove build warnings
2019-03-19 17:22 ` [dpdk-stable] [dpdk-dev] [PATCH v2] meson: remove build warnings Jerin Jacob Kollanukkaran
@ 2019-03-19 17:36 ` Luca Boccassi
2019-03-26 22:32 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2019-03-19 17:36 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, Thomas Monjalon; +Cc: dev, bruce.richardson, stable
On Tue, 2019-03-19 at 17:22 +0000, Jerin Jacob Kollanukkaran wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Remove the following warning by comparing string to string.
>
> config/arm/meson.build:153: WARNING: Trying to compare values of
> different types (list, str) using ==.
>
> Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for
> ARM")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>
> v2: Remove meson version related warning as bumbing the version needs
> techboard approval.
>
> ---
> config/arm/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 8e892fa77..170a4981a 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -116,8 +116,8 @@ else
> cmd_output =
> cmd.stdout().to_lower().strip().split(' ')
> endif
> # Set to generic if variable is not found
> - machine = get_variable('impl_' + cmd_output[0],
> 'generic')
> - if machine == 'generic'
> + machine = get_variable('impl_' + cmd_output[0],
> ['generic'])
> + if machine[0] == 'generic'
> machine = impl_generic
> cmd_output = cmd_generic
> endif
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] meson: remove build warnings
2019-03-19 17:36 ` Luca Boccassi
@ 2019-03-26 22:32 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-03-26 22:32 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran; +Cc: dev, Luca Boccassi, bruce.richardson, stable
19/03/2019 18:36, Luca Boccassi:
> On Tue, 2019-03-19 at 17:22 +0000, Jerin Jacob Kollanukkaran wrote:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Remove the following warning by comparing string to string.
> >
> > config/arm/meson.build:153: WARNING: Trying to compare values of
> > different types (list, str) using ==.
> >
> > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for
> > ARM")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-26 22:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190318162804.28974-1-jerinj@marvell.com>
2019-03-19 17:22 ` [dpdk-stable] [dpdk-dev] [PATCH v2] meson: remove build warnings Jerin Jacob Kollanukkaran
2019-03-19 17:36 ` Luca Boccassi
2019-03-26 22:32 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).