patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Anantharam, Arjun" <arjun.anantharam@intel.com>,
	"Miskell, Timothy" <timothy.miskell@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/iavf: fix TSO max segment size
Date: Fri, 26 Mar 2021 06:49:07 +0000
Message-ID: <1c6a4ae7c54f4df685ae3c4f85427d4d@intel.com> (raw)
In-Reply-To: <MN2PR11MB3807890045F074C651D38D7BF7619@MN2PR11MB3807.namprd11.prod.outlook.com>



> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Friday, March 26, 2021 9:28 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Anantharam, Arjun <arjun.anantharam@intel.com>; Miskell, Timothy
> <timothy.miskell@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] net/iavf: fix TSO max segment size
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Monday, March 1, 2021 3:57 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: Anantharam, Arjun <arjun.anantharam@intel.com>; Miskell, Timothy
> > <timothy.miskell@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> > dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/iavf: fix TSO max segment size
> >
> > According to Intel® AVF spec
> > (https://www.intel.com/content/dam/
> > www/public/us/en/documents/product-specifications/
> > ethernet-adaptive-virtual-function-hardware-spec.pdf)
> > section 2.2.2.3:
> > The max segment size(MSS) of TSO should not be set lower than 88.
> >
> > Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >  drivers/net/iavf/iavf_rxtx.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/iavf/iavf_rxtx.h
> > b/drivers/net/iavf/iavf_rxtx.h index 922ddadad1..69979971fd 100644
> > --- a/drivers/net/iavf/iavf_rxtx.h
> > +++ b/drivers/net/iavf/iavf_rxtx.h
> > @@ -34,7 +34,7 @@
> >  #define DEFAULT_TX_RS_THRESH     32
> >  #define DEFAULT_TX_FREE_THRESH   32
> >
> > -#define IAVF_MIN_TSO_MSS          256
> > +#define IAVF_MIN_TSO_MSS          88
> >  #define IAVF_MAX_TSO_MSS          9668
> >  #define IAVF_TSO_MAX_SEG          UINT8_MAX
> >  #define IAVF_TX_MAX_MTU_SEG       8
> > --
> > 2.26.2
> 
> Acked-by: Beilei Xing <beilei.xing@intel.com>
> 

Applied to dpdk-next-net-intel.

Thanks
Qi


      reply	other threads:[~2021-03-26  6:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01  7:57 Qi Zhang
2021-03-26  1:27 ` Xing, Beilei
2021-03-26  6:49   ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c6a4ae7c54f4df685ae3c4f85427d4d@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=arjun.anantharam@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=stable@dpdk.org \
    --cc=timothy.miskell@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git