From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C5DDA0C43 for ; Wed, 12 May 2021 10:48:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 377CD410FE; Wed, 12 May 2021 10:48:31 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id E164E4003E; Wed, 12 May 2021 10:48:27 +0200 (CEST) IronPort-SDR: Zwt9ugvlikVvJ+uJD52WB8gSTHk1GIf+hucj8nT9SdHL/I8vkBs7h8KSQIUIgVaVMgLBIMGdJ9 Rp8hV0bf6wlg== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="199709216" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="199709216" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 01:48:23 -0700 IronPort-SDR: qURaIbo9EY+dadUZWm1CDnmwXbAIUJ4IQguzp+Eb74aMNqmX9hQL2fUqbVVpZsTBu/JiroSFMH iCaKV/INT4XQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="430649515" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 12 May 2021 01:48:21 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 12 May 2021 01:48:20 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 12 May 2021 16:48:17 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Wed, 12 May 2021 16:48:17 +0800 From: "Zhang, Qi Z" To: "Rong, Leyi" , "Zhang, AlvinX" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] net/i40e: fix offload flag checking in simple Tx datapath Thread-Index: AQHXRkbd3gTEZPIUAkeeXiDI5lwkbqrfinvQ Date: Wed, 12 May 2021 08:48:17 +0000 Message-ID: <1cc3bde5a3ba4d0fbc6214da894e0811@intel.com> References: <20210511023926.27296-1-alvinx.zhang@intel.com> <20210511084531.34044-1-alvinx.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v3] net/i40e: fix offload flag checking in simple Tx datapath X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Rong, Leyi > Sent: Tuesday, May 11, 2021 5:20 PM > To: Zhang, AlvinX ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v3] net/i40e: fix offload flag checking in simple Tx > datapath >=20 >=20 > > -----Original Message----- > > From: Zhang, AlvinX > > Sent: Tuesday, May 11, 2021 4:46 PM > > To: Xing, Beilei ; Rong, Leyi > > > > Cc: dev@dpdk.org; Zhang, AlvinX ; > > stable@dpdk.org > > Subject: [PATCH v3] net/i40e: fix offload flag checking in simple Tx > > datapath > > > > Tx offload flags 'PKT_TX_IPV6, PKT_TX_IPV4, PKT_TX_OUTER_IPV6, > > PKT_TX_OUTER_IPV4' are supported in simple datapath. > > > > This patch removes these offload flags from packet checking in simple > > Tx datapath and defines 2 macro I40E_TX_OFFLOAD_SIMPLE_SUP_MASK > and > > I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK. > > > > Fixes: 146ffa81d05e ("net/i40e: add Tx preparation for simple Tx > > datapath") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alvin Zhang > > --- > > > > v3: Update codes according to comments > > --- > > drivers/net/i40e/i40e_rxtx.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_rxtx.c > > b/drivers/net/i40e/i40e_rxtx.c index 02cf5e7..337916b 100644 > > --- a/drivers/net/i40e/i40e_rxtx.c > > +++ b/drivers/net/i40e/i40e_rxtx.c > > @@ -72,6 +72,15 @@ > > #define I40E_TX_OFFLOAD_NOTSUP_MASK \ > > (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK) > > > > +#define I40E_TX_OFFLOAD_SIMPLE_SUP_MASK ( \ > > + PKT_TX_IPV4 | \ > > + PKT_TX_IPV6 | \ > > + PKT_TX_OUTER_IPV4 | \ > > + PKT_TX_OUTER_IPV6) > > + > > +#define I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK \ > > + (PKT_TX_OFFLOAD_MASK ^ > > I40E_TX_OFFLOAD_SIMPLE_SUP_MASK) > > + > > int > > i40e_get_monitor_addr(void *rx_queue, struct rte_power_monitor_cond > > *pmc) { @@ -1501,7 +1510,7 @@ > > return i; > > } > > > > - if (ol_flags & PKT_TX_OFFLOAD_MASK) { > > + if (ol_flags & I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK) { > > rte_errno =3D ENOTSUP; > > return i; > > } > > -- > > 1.8.3.1 >=20 > Acked-by: Leyi Rong Applied to dpdk-next-net-intel. Thanks Qi