From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E8DBAA0524
	for <public@inbox.dpdk.org>; Tue,  1 Jun 2021 11:19:39 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DF11B40041;
	Tue,  1 Jun 2021 11:19:39 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id B657840DF7
 for <stable@dpdk.org>; Tue,  1 Jun 2021 11:19:38 +0200 (CEST)
Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.57])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FvRM31vHVzWq0H;
 Tue,  1 Jun 2021 17:14:55 +0800 (CST)
Received: from [10.67.103.128] (10.67.103.128) by
 dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.2176.2; Tue, 1 Jun 2021 17:19:36 +0800
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>, Chengwen Feng
 <fengchengwen@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, Lijun Ou
 <oulijun@huawei.com>
CC: dpdk stable <stable@dpdk.org>
References: <CAATJJ0+hWWTxOta4-1JZUWfsWwxVY9kMi-ri29pM5AtdYOrZoA@mail.gmail.com>
From: "Min Hu (Connor)" <humin29@huawei.com>
Message-ID: <1df61eb4-cfdf-cd6a-5c16-5d05a67fa547@huawei.com>
Date: Tue, 1 Jun 2021 17:19:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <CAATJJ0+hWWTxOta4-1JZUWfsWwxVY9kMi-ri29pM5AtdYOrZoA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.128]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 dggeme756-chm.china.huawei.com (10.3.19.102)
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-stable] RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE not present in
 19.11.x series
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

Hi，Christian,
	Agreed, this patch can be abandoned in 19.11x， It can backport
to 20.11.x.

在 2021/6/1 16:25, Christian Ehrhardt 写道:
> Hi,
> this was targeted at the stable releases:
> 
> commit 1bdcca8006e4c690d017531f7fc6c31b19ad8d1d
> Author: Chengwen Feng <fengchengwen@huawei.com>
> Date:   Sat Apr 17 17:54:58 2021 +0800
> 
>      net/hns3: fix flow director lock
> 
> 
> But it introduced
> 
> ../drivers/net/hns3/hns3_flow.c: In function ‘hns3_flow_init’:
> ../drivers/net/hns3/hns3_flow.c:1168:27: error:
> ‘RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE’ undeclared (first use in this
> function)
>   1168 |   dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE;
>        |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/hns3/hns3_flow.c:1168:27: note: each undeclared
> identifier is reported only once for each function it appears in
> 
> 
> The reason is that this was introduced in 20.11
> 
> commit 80d1a9aff7f6088ea97d78e36de3f9edae018f1c
> Author: Suanming Mou <suanmingm@nvidia.com>
> Date:   Thu Oct 15 09:07:47 2020 +0800
> 
>      ethdev: make flow API thread safe
> 
> I'm unsure about the potential implications to e.g. just strip declaring
> RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE from your patch so if you'd want to have
> that one applied ti 19.11.x I'd ask you to have a more detailed look
> and consider providing a backport or letting me know that this patch isn't
> needed for 19.11.x
> 
> Thanks in advance,
> Christian
>