From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1DE8A0C4B for ; Tue, 13 Jul 2021 15:44:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D88A041263; Tue, 13 Jul 2021 15:44:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5E72341263 for ; Tue, 13 Jul 2021 15:44:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626183888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HpZrzvoV7zBLp/069+hLP3gWAQZZ66x2voxfyvgKS24=; b=G0C+n+2vd47XLbykBZfD5/VapfJ/khH8RWbEgqh/aSdmpVwPDpd/Q4r7KkRuVETXrt9SE7 EBfavJhNTgoCIeld3JE5jCw5XKYnl2yw3NA5zzlu1phpRKZuYZcUWiSN0DBzpbhwNkmpns I84+83ru38dSOGY+wVeT/V4IORV/HW0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-b50wBGK4OLWPtpdgg7su-g-1; Tue, 13 Jul 2021 09:44:40 -0400 X-MC-Unique: b50wBGK4OLWPtpdgg7su-g-1 Received: by mail-wm1-f71.google.com with SMTP id k16-20020a7bc3100000b02901d849b41038so547769wmj.7 for ; Tue, 13 Jul 2021 06:44:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HpZrzvoV7zBLp/069+hLP3gWAQZZ66x2voxfyvgKS24=; b=pDNc8ZgQJv8CEMxlc/OsZ2SeGbygmsm2ClLytxkojPn+Eye3bB4aG7xEv1KpaZmD0o a99BHEQvWmmjgYLF9j8KVsw9PVuunjccD7mPTDpQVM+a4rdALrIsJZZYn9m7jcgDo27y DDFQ8UighCI4Aj7K0i9ruT5MzawJC61/JdTpoZi5bPnKbHV7TGccRGw4hjM7XbOX+PQX y8uMkUZMKnFUX3QMJfpFsOuPvmkQfNatJiJxbIbwMkRsijX6RLDF1de3MN0QwEBlLPVz FfRpgqufQtLTtzh3RDrn56lR8L//1jXuu2whoIPSlbrm+3K5tp9sJPQExQbR2zbYQM7U 1AMA== X-Gm-Message-State: AOAM531iorti2TNCKKvmn98LUrRG0zawjd8RND0bkdlI62ohnW1DHGu5 ndOpb/45zrctZrtFJwx81leG12fm/GtcbeimNyVlolVAgWK9PHESfsWwcfx+tRAv6QwtGbtiQU9 sB1q7l7EBFbDIDfvic3fMd+F2ArKCTnOPQ9Bi39TLGOpYbzub8nGEzTEzvQc= X-Received: by 2002:adf:facf:: with SMTP id a15mr5762732wrs.39.1626183879405; Tue, 13 Jul 2021 06:44:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6FGzYe3hjGi+EqGZ2RtSH6iQgRMSyoXVMiFrBuWfRMKoHuJt6qpONImpUyethMKoeay5VEw== X-Received: by 2002:adf:facf:: with SMTP id a15mr5762714wrs.39.1626183879229; Tue, 13 Jul 2021 06:44:39 -0700 (PDT) Received: from [192.168.0.36] ([78.17.79.77]) by smtp.gmail.com with ESMTPSA id d18sm2620802wrw.7.2021.07.13.06.44.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jul 2021 06:44:38 -0700 (PDT) To: "Power, Ciara" , "Zhang, AlvinX" , "christian.ehrhardt@canonical.com" , "Chen, LingliX" , "Jiang, YuX" , "Van Haaren, Harry" Cc: "stable@dpdk.org" References: <20210713064137.12488-1-alvinx.zhang@intel.com> From: Kevin Traynor Message-ID: <1e663aa8-782b-e711-ecf7-ae3253c9f7ae@redhat.com> Date: Tue, 13 Jul 2021 14:44:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH v4] telemetry: fix race in telemetry control thread creation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 13/07/2021 14:31, Power, Ciara wrote: > Hi Alvin, > >> -----Original Message----- >> From: Zhang, AlvinX >> Sent: Tuesday 13 July 2021 07:42 >> To: christian.ehrhardt@canonical.com; Chen, LingliX ; >> Jiang, YuX ; Power, Ciara ; Van >> Haaren, Harry >> Cc: Zhang, AlvinX ; stable@dpdk.org >> Subject: [PATCH v4] telemetry: fix race in telemetry control thread creation >> >> Before the caller returns from function "rte_ctrl_thread_create", the newly >> created thread may have ran, and because the thread control flag was not set >> before, the new thread may exit soon. >> This is not what the developer expected. >> >> This patch puts the setting thread control flag to the place that before creating >> new thread. >> >> Reported-at: https://bugs.dpdk.org/show_bug.cgi?id=731 >> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") >> Cc: stable@dpdk.org >> >> Signed-off-by: Alvin Zhang >> --- >> > > > Thanks for this, I guess it is targeted towards both 18.11 and 19.11 stable releases? 18.11 LTS is no longer maintained, so it would just be a candidate for 19.11 but I guess that was the intent looking at the Bz. > This file was removed in 20.11 so won't be needed there. > > Acked-by: Ciara Power > >