patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Chas Williams <3chas3@gmail.com>
To: Jiang JunyuX <junyux.jiang@intel.com>, dev@dpdk.org
Cc: Chas Williams <chas3@att.com>,
	Yang Qiming <qiming.yang@intel.com>,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net/bonding: fix invalid port using
Date: Tue, 29 Oct 2019 11:59:11 -0400
Message-ID: <1f52050c-b5d4-f4b1-c24e-36cef00c2d89@gmail.com> (raw)
In-Reply-To: <20191029022341.5780-1-junyux.jiang@intel.com>

On 10/28/19 10:23 PM, Jiang JunyuX wrote:
> Port validation should be prior to getting device data
> to avoid segment fault. This patch fixed the segment fault
> caused by invalid port using.
> 
> Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes")
> Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiang JunyuX <junyux.jiang@intel.com>

Acked-by: Chas Williams <chas3@att.com>

Patchwork says that there is a build error but it doesn't seem to
be related to this change.

> ---
>   drivers/net/bonding/rte_eth_bond_8023ad.c | 32 ++++++++++++++++-------
>   1 file changed, 22 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index 7d8da2b31..682854e39 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -1387,11 +1387,12 @@ rte_eth_bond_8023ad_agg_selection_set(uint16_t port_id,
>   	struct bond_dev_private *internals;
>   	struct mode8023ad_private *mode4;
>   
> +	if (valid_bonded_port_id(port_id) != 0)
> +		return -EINVAL;
> +
>   	bond_dev = &rte_eth_devices[port_id];
>   	internals = bond_dev->data->dev_private;
>   
> -	if (valid_bonded_port_id(port_id) != 0)
> -		return -EINVAL;
>   	if (internals->mode != 4)
>   		return -EINVAL;
>   
> @@ -1408,11 +1409,12 @@ int rte_eth_bond_8023ad_agg_selection_get(uint16_t port_id)
>   	struct bond_dev_private *internals;
>   	struct mode8023ad_private *mode4;
>   
> +	if (valid_bonded_port_id(port_id) != 0)
> +		return -EINVAL;
> +
>   	bond_dev = &rte_eth_devices[port_id];
>   	internals = bond_dev->data->dev_private;
>   
> -	if (valid_bonded_port_id(port_id) != 0)
> -		return -EINVAL;
>   	if (internals->mode != 4)
>   		return -EINVAL;
>   	mode4 = &internals->mode4;
> @@ -1665,9 +1667,14 @@ int
>   rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
>   {
>   	int retval = 0;
> -	struct rte_eth_dev *dev = &rte_eth_devices[port];
> -	struct bond_dev_private *internals = (struct bond_dev_private *)
> -		dev->data->dev_private;
> +	struct rte_eth_dev *dev;
> +	struct bond_dev_private *internals;
> +
> +	if (valid_bonded_port_id(port) != 0)
> +		return -EINVAL;
> +
> +	dev = &rte_eth_devices[port];
> +	internals = dev->data->dev_private;
>   
>   	if (check_for_bonded_ethdev(dev) != 0)
>   		return -1;
> @@ -1689,9 +1696,14 @@ int
>   rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
>   {
>   	int retval = 0;
> -	struct rte_eth_dev *dev = &rte_eth_devices[port];
> -	struct bond_dev_private *internals = (struct bond_dev_private *)
> -		dev->data->dev_private;
> +	struct rte_eth_dev *dev;
> +	struct bond_dev_private *internals;
> +
> +	if (valid_bonded_port_id(port) != 0)
> +		return -EINVAL;
> +
> +	dev = &rte_eth_devices[port];
> +	internals = dev->data->dev_private;
>   
>   	if (check_for_bonded_ethdev(dev) != 0)
>   		return -1;
> 

  reply	other threads:[~2019-10-29 15:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 20:55 [dpdk-stable] [PATCH] net/bonding: fix segfault using invalid port Jiang JunyuX
2019-10-28  5:42 ` Yang, Qiming
2019-10-29  3:04   ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-10-29  6:15     ` Yang, Qiming
2019-10-29  6:25       ` Ye Xiaolong
2019-10-29  8:32         ` Yang, Qiming
2019-10-28 20:19 ` [dpdk-stable] [PATCH v2] " Jiang JunyuX
2019-10-28 20:48   ` [dpdk-stable] [PATCH v3] net/bonding: fix invalid port using Jiang JunyuX
2019-10-29  2:23     ` [dpdk-stable] [PATCH v4] " Jiang JunyuX
2019-10-29 15:59       ` Chas Williams [this message]
2019-10-30  8:48         ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-10-30  2:24       ` [dpdk-stable] " Yang, Qiming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f52050c-b5d4-f4b1-c24e-36cef00c2d89@gmail.com \
    --to=3chas3@gmail.com \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    --cc=junyux.jiang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git