From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 299A11D6FE; Fri, 15 Jun 2018 10:24:20 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jun 2018 01:24:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,226,1526367600"; d="scan'208";a="208312542" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga004.jf.intel.com with SMTP; 15 Jun 2018 01:24:16 -0700 Received: by (sSMTP sendmail emulation); Fri, 15 Jun 2018 09:24:15 +0100 Date: Fri, 15 Jun 2018 09:24:14 +0100 From: Bruce Richardson To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org Message-ID: <20180615082414.GA23520@bricha3-MOBL.ger.corp.intel.com> References: <20180615070811.18686-1-gavin.hu@arm.com> <20180615080120.29253-1-gavin.hu@arm.com> <20180615080120.29253-5-gavin.hu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180615080120.29253-5-gavin.hu@arm.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v8 4/6] devtools: fix the missing ninja command error on CentOS X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 08:24:21 -0000 On Fri, Jun 15, 2018 at 04:01:18PM +0800, Gavin Hu wrote: > On CentOS, the ninja executable has a different name: > ninja-build, this patch is to fix the missing command error > on CentOS as follows: > ./devtools/test-meson-builds.sh: line 24: ninja: command not found > > Fixes: a55277a788 ("devtools: add test script for meson builds") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Phil Yang > Reviewed-by: Song Zhu > --- > devtools/test-meson-builds.sh | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index f2ad05f32..8447c704b 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -10,6 +10,15 @@ > srcdir=$(dirname $(readlink -m $0))/.. > MESON=${MESON:-meson} > > +if command -v ninja >/dev/null 2>&1 ; then > + ninja_cmd=ninja > +elif command -v ninja-build >/dev/null 2>&1 ; then > + ninja_cmd=ninja-build > +else > + echo "## ERROR: ninja is missing, please install..." > + exit 1 > +fi > + > build () # > { > builddir=$1 > @@ -21,7 +30,7 @@ build () # > unset CC > fi > echo "ninja -C $builddir" > - ninja -C $builddir > + $ninja_cmd -C $builddir I think the command-name should be updated in the echo print too. [Perhaps that can be done on apply]. With that minor change: Acked-by: Bruce Richardson