From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id C11C5292D;
Tue, 19 Jun 2018 14:30:23 +0200 (CEST)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
19 Jun 2018 05:30:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,243,1526367600"; d="scan'208";a="65388368"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107])
by fmsmga001.fm.intel.com with SMTP; 19 Jun 2018 05:30:10 -0700
Received: by (sSMTP sendmail emulation); Tue, 19 Jun 2018 13:30:09 +0100
Date: Tue, 19 Jun 2018 13:30:09 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Gavin Hu <Gavin.Hu@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Message-ID: <20180619123009.GA20032@bricha3-MOBL.ger.corp.intel.com>
References: <20180615102143.12778-1-gavin.hu@arm.com>
<20180619013746.13268-1-gavin.hu@arm.com>
<20180619013746.13268-5-gavin.hu@arm.com>
<20180619101220.GB23348@bricha3-MOBL.ger.corp.intel.com>
<VI1PR08MB31677459DC6C5CC3D58C66228F700@VI1PR08MB3167.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <VI1PR08MB31677459DC6C5CC3D58C66228F700@VI1PR08MB3167.eurprd08.prod.outlook.com>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.10.0 (2018-05-17)
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v11 4/6] devtools: fix the
missing ninja command error
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2018 12:30:25 -0000
On Tue, Jun 19, 2018 at 10:41:06AM +0000, Gavin Hu wrote:
> Hi Bruce,
>
> Thanks for your review, I submitted v12 patch to address all your new comments.
>
> BTW, do you know why pwclient can NOT work successfully today?
> It worked fine at my side previously, any changes at the server side? The error is below:
> xmlrpc.client.ProtocolError: <ProtocolError for dpdk.org/dev/patchwork/xmlrpc/: 301 Moved Permanently>
>
> Best Regards,
> Gavin
Paths on the server have changed, so you need to update your .pwclientrc
file to point to the new path. Patchwork is now at "patches.dpdk.org"
>
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Tuesday, June 19, 2018 6:12 PM
> > To: Gavin Hu <Gavin.Hu@arm.com>
> > Cc: dev@dpdk.org; nd <nd@arm.com>; stable@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v11 4/6] devtools: fix the missing ninja
> > command error
> >
> > On Tue, Jun 19, 2018 at 09:37:44AM +0800, Gavin Hu wrote:
> > > On some linux distributions, eg: CentOS, the ninja executable has a
> > > different name: ninja-build, this patch is to check and adapt to it
> > > accordingly.
> > >
> > > ./devtools/test-meson-builds.sh: line 24: ninja: command not found
> > >
> > > Fixes: a55277a788 ("devtools: add test script for meson builds")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > > Reviewed-by: Song Zhu <song.zhu@arm.com>
> > > ---
> > This is previously acked.