From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
dpdk stable <stable@dpdk.org>,
"Xueming(Steven) Li" <xuemingl@mellanox.com>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix error number handling
Date: Wed, 20 Jun 2018 09:05:13 +0200 [thread overview]
Message-ID: <20180620070513.4n2cgonoudruupyh@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <939801BC-1FFD-4770-A491-81E2F3D847C2@mellanox.com>
On Tue, Jun 19, 2018 at 11:00:25PM +0000, Yongseok Koh wrote:
>[...]
> >>> I did not understood it was only a concern about the success of the
> >>> function, even it is better to avoid as most as possible a useless
> >>> store, in this specific case, as errno (rte_errno) has a garbage value,
> >>> I fully agree with you.
> >>
> >> Nelio,
> >>
> >> Do you still want me to make any change for this patch?
> >> Let me know if any.
> >
> > With your modification the function documentation is no more accurate as
> > rte_errno is always set.
>
> I still don't agree with that but will send out v2. It's not a big deal.
What I meant is, you could have only changed the function documentation.
@return
0 on success with rte_errno always set, negative errno otherwise.
letting the function documentation saying rte_errno is only modified in
case of error whereas it is not is a bug or in the documentation or in
the code, but as a function must respect its documentation, it would
have raised a bug in the code itself.
Regards,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-06-20 7:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 17:37 Yongseok Koh
2018-06-05 6:52 ` Nélio Laranjeiro
2018-06-05 21:36 ` Yongseok Koh
2018-06-06 6:55 ` Nélio Laranjeiro
2018-06-06 18:39 ` Yongseok Koh
2018-06-07 7:39 ` Nélio Laranjeiro
2018-06-18 17:06 ` Yongseok Koh
2018-06-19 11:48 ` Nélio Laranjeiro
2018-06-19 23:00 ` Yongseok Koh
2018-06-20 7:05 ` Nélio Laranjeiro [this message]
2018-06-19 23:13 ` [dpdk-stable] [PATCH v2] " Yongseok Koh
2018-06-20 7:02 ` Nélio Laranjeiro
2018-06-21 10:57 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620070513.4n2cgonoudruupyh@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=xuemingl@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).