From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id B23EC2BC8; Mon, 25 Jun 2018 16:40:50 +0200 (CEST) Received: from rsa59-2-82-233-193-189.fbx.proxad.net ([82.233.193.189] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fXSgC-0001m2-Id; Mon, 25 Jun 2018 16:41:22 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 25 Jun 2018 16:40:47 +0200 Date: Mon, 25 Jun 2018 16:40:47 +0200 From: Olivier Matz To: "Burakov, Anatoly" Cc: Dariusz Stojaczyk , dev@dpdk.org, stable@dpdk.org Message-ID: <20180625144047.ktlcpstkfcmyhxcl@platinum> References: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com> <1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com> <387954ec-779e-6f29-5966-f8d2a41945e1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <387954ec-779e-6f29-5966-f8d2a41945e1@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create() X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 14:40:50 -0000 On Mon, Jun 18, 2018 at 11:01:40AM +0100, Burakov, Anatoly wrote: > On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote: > > This function returned positive error numbers instead > > of negative ones as desbribed in the doc. What's worse, > > multiple of its callers only check for (rc < 0) to detect > > failure. > > > > It was incorrectly assumed that pthread_create > > and pthread_setaffinity_np return negative errnos. They > > always returns positive ones, so this patch negates their > > return values before returning. > > > > Fixes: 9e5afc72c909 ("eal: add function to create control threads") > > Cc: olivier.matz@6wind.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Dariusz Stojaczyk > > --- > > Acked-by: Anatoly Burakov Reviewed-by: Olivier Matz Thanks for the fix.