From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id E0E8B98 for ; Tue, 24 Jul 2018 18:09:08 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id b15-v6so4686849wrv.10 for ; Tue, 24 Jul 2018 09:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JkBn0EvHbXo9SoqPkmeOmIqb6U64lFaZEaO5OQLfAj4=; b=htxiTNScguNBIkSi3meU5H+yO2w8LUWWtu+Vxljrh3L1hRaxl4/El8KFJudcWeJkD7 MYsurVRV5MKCtDfik2A37WmA5JyXcHhh1Mxgvv5Cer3o+8nhfLWSoKGNOQ1t35P4g7XR qZqPNvsRqaO7NueCbmPx5jJ6UFdrSfCoApueL71MSdSir+xBwQUqiE0HWz5+UbDUvxY2 aiPZjRdvN+ftIL4L4Ph+v1EybZo7KzwdwwK7rIKrTmyPXxwRFUFo6AcEZRr2RBfGem4g uTwTYZlcl4ISq1ClGOp4AH9C0RQ1Oun0D0m53Mz9NGyAXc5IRz9nsQilhXD8sjL2gd5C LyjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JkBn0EvHbXo9SoqPkmeOmIqb6U64lFaZEaO5OQLfAj4=; b=bqvpxyJlc5/irHwWX75pKZMrXnOIqn6YZ28croSLMWTs2zIpYQ6/T+XHpCgWBAx4dJ cPofpGykvOFDbUIu3syU53/AUjc94tVDKRgXG10Xlk0ALnADwHmKodVacuxZcxgiAnnZ ffUKd4aHDFCgjnt2WNQe747xcSomADW+NWkLfXQRrOAVfIs+Ir9Aml7RaWfTrti1g5za tdwO4r2Adz+qz2ZRh3FcEWCUBLkuaY4kBdzXjfaEFC4sjEQSTkoubSz92qSg5UJwp+BT C32lDjq68R/Ye/OsjF0XAzr+WEGezNL+5emvScw713NHgC0lJhl+mAoG8Tq/AB3yZSZ3 +/cA== X-Gm-Message-State: AOUpUlFWjbfqqcpabZST/EJMjAwxC8a0qqS3rdz2xF5so/rLYib4muCB DY77GVs0OjuckSGG4Sd4jwA= X-Google-Smtp-Source: AAOMgpcaKbnwMzUvfPsT6K6K1ni4xUbPoNW/nGEmJnRhwRK9IobSwvAhnizj4gcokmeXKCm3r36D7g== X-Received: by 2002:adf:a64d:: with SMTP id k71-v6mr11876400wrc.78.1532448548642; Tue, 24 Jul 2018 09:09:08 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id x184-v6sm2593129wmg.24.2018.07.24.09.09.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jul 2018 09:09:07 -0700 (PDT) From: luca.boccassi@gmail.com To: Chas Williams Cc: dpdk stable Date: Tue, 24 Jul 2018 17:07:43 +0100 Message-Id: <20180724160752.20287-25-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180724160752.20287-1-luca.boccassi@gmail.com> References: <20180724160752.20287-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/bonding: do not clear active slave count' has been queued to LTS release 16.11.8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 16:09:09 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 61a342dbaac59371580d6bf5e14aed71639d570a Mon Sep 17 00:00:00 2001 From: Chas Williams Date: Tue, 3 Jul 2018 22:28:32 -0400 Subject: [PATCH] net/bonding: do not clear active slave count [ upstream commit 69bce062132bd2b4a943fafbb710215a7999d198 ] When the bond PMD is stopped, the active slave count is reset. For 802.3ad mode this potentially leaks memory and clears state since a second sequential activate_slave() will occur when the bond PMD is restarted and the LSC callback is triggered while the active slave count is 0. To fix this, don't clear the active slave count when stopping. Only deactivate_slave() should be used to clear the slaves. Fixes: 2efb58cbab6e ("bond: new link bonding library") Signed-off-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 6f8931ef9..5905c7070 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1649,7 +1649,6 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev) tlb_last_obytets[internals->active_slaves[i]] = 0; } - internals->active_slave_count = 0; internals->link_status_polling_enabled = 0; for (i = 0; i < internals->slave_count; i++) internals->slaves[i].last_link_status = 0; -- 2.18.0