From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 7873E160 for ; Tue, 24 Jul 2018 18:09:21 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id a3-v6so4715511wrt.2 for ; Tue, 24 Jul 2018 09:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YbQkerlGmHQOQLHMXkCc/LapBvgevL9e3LfrbrMslk4=; b=eGs/Yjtwn4ltlcdo1K/HcUr4wm7pP319SEqfGNnGsjq9lR6+dHYEMfdfEGVD7tSsN5 RE4IKmNwUqgkhOeT/z0Y7Zin4+hdTmFjjaFwMa5veGX9IhwBbT9eNWnq7TZXeJd6/ni5 YcXDuToyyPZbkgPwBR4KToaxf6lRoRf+UGLoPrzZ0K4lt6yVW1dw+njwRw9W8RMarPbP ZLuGz9cEj4lPEQzsKvAsRrWGpIfFbU1fvTCxle/uvY+2boJao70EJbAMosOqbRgqFb23 DviS6E03q1Vy3CSga8o9SE9tcFZIdta0IimLBphQGXLd2qA+aziqpTangE+nXbF6qGOa UQqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YbQkerlGmHQOQLHMXkCc/LapBvgevL9e3LfrbrMslk4=; b=sdZ1mMY6W09qZq3MiK2DWkT4OAbrdRImRDWCVCQxwlvYnv4Txwhc5RMaJCk/DCXpwK osbTFSNb6qbfAxioEFQJAYGxPKMTkgdd3BXeSFkFZfM9+thc2A0n+RDAjsZ6SnxrcKpK h0ilBs1riWPEfbreOcqL7dZaWMFy3xQrppl/DR97HGInXUlywgKo+AziJlGQVUiAGaRJ 1ysdYhwJdpvrriLNAy5ERQnsoGZKdgYub2QQnfb9kh8Vp1z/nDF3aBUMLha6GyMRZN3I gZDf9sHfPB2DyX9HWMQ909KHZynqpv5kXCN+8hYoDnzKs50ER2dRqlBrB5TObBaBwJZH /RVA== X-Gm-Message-State: AOUpUlEBmQ7t+WVUWz5kKhAJQ02pXO1wkSwbAeQ9bP1q7Sv44H7VwaLq F3IZiQkvJTjv+MIevhbgnBo= X-Google-Smtp-Source: AAOMgpe4xQL003/OaRez7xtV5vGQCO8rqVq/a3RZhWsjvamvW/ZGhaGIXLxvD1MNKFt7xc1GEMYPtA== X-Received: by 2002:a5d:6892:: with SMTP id h18-v6mr12008911wru.108.1532448561280; Tue, 24 Jul 2018 09:09:21 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id q11-v6sm18056686wrp.58.2018.07.24.09.09.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jul 2018 09:09:20 -0700 (PDT) From: luca.boccassi@gmail.com To: Dariusz Stojaczyk Cc: Anatoly Burakov , Olivier Matz , dpdk stable Date: Tue, 24 Jul 2018 17:07:50 +0100 Message-Id: <20180724160752.20287-32-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180724160752.20287-1-luca.boccassi@gmail.com> References: <20180724160752.20287-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'eal: fix return codes on thread naming failure' has been queued to LTS release 16.11.8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 16:09:21 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 77391432e13177760caa74d6b430f75fdb66cd01 Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Tue, 10 Jul 2018 12:44:46 +0200 Subject: [PATCH] eal: fix return codes on thread naming failure [ upstream commit 82dcc8b4bcb8adcb7fc819839833e74a3d0ad497 ] The doc says this function returns negative errno on error, but it currently returns either -1 or positive errno. It was incorrectly assumed that pthread_setname_np() returns negative error numbers. It always returns positive ones, so this patch negates its return value before returning. Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBSD") Signed-off-by: Dariusz Stojaczyk Acked-by: Anatoly Burakov Reviewed-by: Olivier Matz --- lib/librte_eal/linuxapp/eal/eal_thread.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_thread.c b/lib/librte_eal/linuxapp/eal/eal_thread.c index 9f88530ea..da7dd69aa 100644 --- a/lib/librte_eal/linuxapp/eal/eal_thread.c +++ b/lib/librte_eal/linuxapp/eal/eal_thread.c @@ -200,7 +200,7 @@ int rte_sys_gettid(void) int rte_thread_setname(pthread_t id, const char *name) { - int ret = -1; + int ret = ENOSYS; #if defined(__GLIBC__) && defined(__GLIBC_PREREQ) #if __GLIBC_PREREQ(2, 12) ret = pthread_setname_np(id, name); @@ -208,5 +208,5 @@ int rte_thread_setname(pthread_t id, const char *name) #endif RTE_SET_USED(id); RTE_SET_USED(name); - return ret; + return -ret; } -- 2.18.0