From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by dpdk.org (Postfix) with ESMTP id 0F410239 for ; Tue, 24 Jul 2018 18:09:25 +0200 (CEST) Received: by mail-wr1-f54.google.com with SMTP id g6-v6so4725800wrp.0 for ; Tue, 24 Jul 2018 09:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cHXRS/lUJrBQcrZvlR6eAB8T02qrn8kpq0O/GB7sw3I=; b=RZ70nsm9Rn+5WoRjqX7ibl452apsT76nwYBX9mP5Ex2EKN4tx5+2JsH8m+THYnNyfw u26d0KguvKNSg8IR58KfRgHRS7TR7en/b+bUcTs+0h0/1LBq4G+UCU+URf32vMxybYc5 QPw9T5f/qGU8nuzwT9Hlb1QKuPEFyWZYuxXgYUzEbHu/GbnthiovdMIM5iJ+n0NRYjgk /tiLb8hI1RaPbZ1cDq35KK8s4eGGyRb0/OfD/hOQ42RIm7BscMQ1/HSV+78L68FN/n2I 5Gne9kOaDnwxkSykivbMfFUtBiWJfQWXVoG00An+UxIN9Nt4VDDPAqrNJ/2GJ8WZ9WRa 5AJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cHXRS/lUJrBQcrZvlR6eAB8T02qrn8kpq0O/GB7sw3I=; b=AHa/QcAQ+sBls0+1e7HGFHpsKlmtkMqXoOs1/4Dl9KtWyo0ENMKxcToWU8AAMDP8yB ojdkY2Hd2FYmMA4pJHF/JYHp6n4T1CeweUuhTJbvT34pn7udQb+18OSDjq7Y2oIocKot 9OsAz0ds+qaoDXAxfIZDNf2R6NdA4rFJkhESG3QpZS7XjqMoJq+72N7nMbFQnxD6yCx7 2zrGp1hJS7oWqkcERLQQmhJJjWbrzCLumVjmLDA75Q4iDoUOo3IeNeW/yiHbyTVxQPZH KG+cT4Pz1Qi6uSZVSHjiE3mkParftj7YC+cZZFpOM1YHu+kufjOOP8lbGDPVHp/Gm5kk LxnA== X-Gm-Message-State: AOUpUlGHnIw1ZlnQjjwURoWRDznP/mQCTyef7jwyScHTtiaQZsnOzcKr EMeKMdXfdtHSfVACxOxhoZ4Ru+hhZi0= X-Google-Smtp-Source: AAOMgpcLaLBwsIOok4BfF7OEGPEkgQqTj6rcPBWK8dO3sJj2xvLfOJNu4wrLE/RCI63qf18r7ShjHg== X-Received: by 2002:adf:a963:: with SMTP id u90-v6mr13010195wrc.248.1532448564834; Tue, 24 Jul 2018 09:09:24 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id d15-v6sm3440032wmb.0.2018.07.24.09.09.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jul 2018 09:09:23 -0700 (PDT) From: luca.boccassi@gmail.com To: Kiran Kumar Cc: Andrew Rybchenko , dpdk stable Date: Tue, 24 Jul 2018 17:07:52 +0100 Message-Id: <20180724160752.20287-34-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180724160752.20287-1-luca.boccassi@gmail.com> References: <20180724160752.20287-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'ethdev: check queue stats mapping input arguments' has been queued to LTS release 16.11.8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 16:09:25 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 7e0f3ceda8a6a58107ee9ab8618ffc07edeb4d2e Mon Sep 17 00:00:00 2001 From: Kiran Kumar Date: Wed, 11 Jul 2018 14:11:59 +0530 Subject: [PATCH] ethdev: check queue stats mapping input arguments [ upstream commit de9c75a5485832104d2a0c246544ba3a511802b4 ] With current implementation, we are not checking for queue_id range and stat_idx range in stats mapping function. This patch will add check for queue_id and stat_idx range. Fixes: 5de201df892 ("ethdev: add stats per queue") Signed-off-by: Kiran Kumar Acked-by: Andrew Rybchenko --- lib/librte_ether/rte_ethdev.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index a698fc00a..9b28e95ae 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -1598,6 +1598,16 @@ set_queue_stats_mapping(uint8_t port_id, uint16_t queue_id, uint8_t stat_idx, dev = &rte_eth_devices[port_id]; RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_stats_mapping_set, -ENOTSUP); + + if (is_rx && (queue_id >= dev->data->nb_rx_queues)) + return -EINVAL; + + if (!is_rx && (queue_id >= dev->data->nb_tx_queues)) + return -EINVAL; + + if (stat_idx >= RTE_ETHDEV_QUEUE_STAT_CNTRS) + return -EINVAL; + return (*dev->dev_ops->queue_stats_mapping_set) (dev, queue_id, stat_idx, is_rx); } -- 2.18.0