From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id A9A0398 for ; Tue, 24 Jul 2018 18:08:21 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id y2-v6so2483407wma.1 for ; Tue, 24 Jul 2018 09:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=t0uhHdecAmG8/RRRJFxcoJ3MKr/EvE1MsJeKXwG+L14=; b=b3HSz/Hc2WkOwoFPlAkDzSR2GR3qO1jORlAgzAiix2SBmEZI8kv62jvg0zSJBtL8ww BKnju/PaJOZOHcaJLxmLppftKN1mNJVzmViPiGgS1+oD8Hy9t29MLwXn1mh6g26LY0F0 JQsBQn2hbnFByBFB6k1THn5DtmaERBeyKBs8EKA4ZrGVpbzpvcGUFN/Ntm/tfG2RoNBt xCfQATQckNEMFk/rVBBw/E8PU43fK1V5uxu7tWHmlqn9y7tEIN18aWVb44Qg5kuTVTLf NgCp9Ojlf809yFaWUtgPGGYtiTYcupbTfU7pplOYtbwuU1yMq8bDXt3SxD25QHGsf2XC /hOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=t0uhHdecAmG8/RRRJFxcoJ3MKr/EvE1MsJeKXwG+L14=; b=qJADTLSJVDqzIsila5RXKBaPkYlKXtoClf3FWcyXyEOEJ2JnWsoxl3KIFTRtBNhjW8 t98tClIShxlL66yEh7sPoIJAW/SnhsT+xWSEhRqesa/cVzhxzu+RUoeUd2FlgnHqLdpN 6S9W6x66bF3NtUpVWCGac9sOr+GzKqIBnUHqb867BFc2dGBvL58V3DJc175oBHGjrkDG 3s6viyQhoKh/c0pH+OXGI/PZjKCJVpFdxmbapAKGLP9qdp5caYnaArgIiA95AAgZFHZH GqKWW7wTv02W2v2IFPzAaYrjjpk1jQ87TI+hzo8DtP0N/hQ0AOAQOoYw4zXn4bcunsVh 228A== X-Gm-Message-State: AOUpUlFG+8xNhBNtqblurd/5wi9lATakEYCT667J9C3t9qvjsQ127fgj TYr68ERjsiilYZekBhv6kET5wPuoxSc= X-Google-Smtp-Source: AAOMgpdbJhbm1jYGJCiRCp8UirSLmc0/EyR16/EtvhF0Dv6M7kaiIuXPj3uhTIqAR8jFMiRUXRThxQ== X-Received: by 2002:a1c:ad42:: with SMTP id w63-v6mr2523585wme.100.1532448501416; Tue, 24 Jul 2018 09:08:21 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id d7-v6sm8867239wro.92.2018.07.24.09.08.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jul 2018 09:08:20 -0700 (PDT) From: luca.boccassi@gmail.com To: Alejandro Lucero Cc: dpdk stable Date: Tue, 24 Jul 2018 17:07:23 +0100 Message-Id: <20180724160752.20287-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180724160752.20287-1-luca.boccassi@gmail.com> References: <20180724160752.20287-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/nfp: fix field initialization in Tx descriptor' has been queued to LTS release 16.11.8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 16:08:21 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 014c7deb627bbc57d887c4cf1e39b342e6aed320 Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Mon, 11 Jun 2018 10:50:37 +0100 Subject: [PATCH] net/nfp: fix field initialization in Tx descriptor [ upstream commit 01f65293ceb94921a35554fa7b17bc0ec1764c96 ] TX descriptor eop_offset field is not initialized and it could contain garbage. This patch fixes the potential problem setting EOP as the only subfield. The other subfield, data offset, is not used by now. Fixes: b812daadad0d ("nfp: add Rx and Tx") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 458114982..0f0589e06 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -2023,11 +2023,15 @@ nfp_net_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txq->tail = 0; pkt_size -= dma_size; - if (!pkt_size) { - /* End of packet */ - txds->offset_eop |= PCIE_DESC_TX_EOP; - } else { - txds->offset_eop &= PCIE_DESC_TX_OFFSET_MASK; + + /* + * Making the EOP, packets with just one segment + * the priority + */ + if (likely(!pkt_size)) + txds->offset_eop = PCIE_DESC_TX_EOP; + else { + txds->offset_eop = 0; pkt = pkt->next; } /* Referencing next free TX descriptor */ -- 2.18.0