From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 5FC11378E for ; Fri, 27 Jul 2018 12:18:01 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id t25-v6so4892832wmi.3 for ; Fri, 27 Jul 2018 03:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ESJgcsAtLA6e8DeqDNaMrGRYVIIFvMqFJmsd8/w7iOw=; b=EOiswWl0V9wplaqqwYNOogOYKonMfXIZpTsMifXqtEGPVrT35XCpH2MpIrHshKmedg uP2TKYg3+zD7x4Cf7TFr2x57JIXieSuGshWCK6TbG/qUgHIWLYbfCg2qNt6VFIHhFzKI jj633Me1jHXUhbyX5vvtPsAqxLWddSMiRldF2epX30Lseqp4Pw+U6Q8esab0h97s68ud PFql+GKNJrIFJGd7+Nc9hG7HRZtlD5Iq7rwFsQzlyPUTztVtKXvwEcNKJmqYkv97lyAk cOb6x1Az8BTmm4IZecpMZDH2AYv55YYshDPnDo3DHIkgBMIczEWaM6cHM+g3e/xnkyAq evKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ESJgcsAtLA6e8DeqDNaMrGRYVIIFvMqFJmsd8/w7iOw=; b=NBe3z3uBJrcn5DlZJO/jAUKO8PP+I1QWrwa8GwlMx+x3F239I8dZOfzkKhclJ1pFoa HabdiwlJ/YXs6aCr20XLVf+WXHVrPMTbzI8nBbZKXjR7PbVZWpolxvwBReubW12hciR2 7CBR5PlpCIzYb1mRecd/Hd+/lTY4PSxOgHPw3DN3/1vK1sbn20iS1XCkuwpmeCSzwLIq l8fzy6ZpY00i5UHWtlHCq8IDYq5My0kt005n61FYW65uBxRnp90sXsuXFn4qR+DiYUZF +i3oGu+qJXNS6BqDElBdY1D1fNeiURirthmrtuVPo1bCmu44zyS8QiE+Nkvo2rKxy/8r OZNQ== X-Gm-Message-State: AOUpUlGogBQyBChYO/LzBTwa0A6gtW5a5BvlCA8SfH/5+TnIxPPDNfBD tuZtBXLIWQ8hHedy1u/KjT0= X-Google-Smtp-Source: AAOMgpeU5Qqe3zZ0Z1KXv3cTHwdUGBAacWhBdKgOzfAiF+bMAixFQK+ThN+jHAAezGdMYTezxzJ/Lw== X-Received: by 2002:a1c:3:: with SMTP id 3-v6mr3627048wma.99.1532686681134; Fri, 27 Jul 2018 03:18:01 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id v5-v6sm7007565wrp.87.2018.07.27.03.17.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Jul 2018 03:18:00 -0700 (PDT) From: luca.boccassi@gmail.com To: Wei Zhao Cc: Qi Zhang , dpdk stable Date: Fri, 27 Jul 2018 11:17:40 +0100 Message-Id: <20180727101748.30228-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180727101748.30228-1-luca.boccassi@gmail.com> References: <20180724160752.20287-34-luca.boccassi@gmail.com> <20180727101748.30228-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/i40e: fix check of flow director programming status' has been queued to LTS release 16.11.8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 10:18:01 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/29/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From dd07790ba3868d42faf03efd5c51856c4fc99b3b Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Fri, 13 Jul 2018 11:16:33 +0800 Subject: [PATCH] net/i40e: fix check of flow director programming status [ upstream commit 7546dc4a1331340ecb665af9af0a005bb8b657c8 ] In i40e FDIR PMD code for checking programming status function i40e_check_fdir_programming_status(), the initial value of return value ret should be set to -1 not 0, because if DD bit of I40E_RX_DESC_STATUS_DD is not write back, this function will return 0 to upper function, this give an error info to upper function, the fact for this is it is time out for DD write back and it should return -1. Fixes: 05999aab4ca6 ("i40e: add or delete flow director") Signed-off-by: Wei Zhao Acked-by: Qi Zhang --- drivers/net/i40e/i40e_fdir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index e25b8e0c4..25578257d 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1020,6 +1020,8 @@ i40e_check_fdir_programming_status(struct i40e_rx_queue *rxq) I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); else I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_tail - 1); + } else { + ret = -1; } return ret; -- 2.18.0