From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 0690C4CC3 for ; Fri, 27 Jul 2018 12:18:05 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id s14-v6so4948558wmc.1 for ; Fri, 27 Jul 2018 03:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E69YJDPLlaXVokQBDjgY9obnVVyQ0ujfRRcHSXK0Kp8=; b=SE64dMvxYmkhysXkzp1fmDyZpDSpZw8xfHPG8wBCOa3pNKdgY/YEd+ifl0Wzf/nIHw 6x6SXZV9gzgYe+MGJtz8K2CVlWqGlpMJwp78vP4aAi79yM4qliUOKpWnpKqy0bOClT1A yz0bwYjv8xsmRmkT25YFwwjRfcQMQm4Rl69g3OPoYMQe4gIj0jIkHBT8XTe8gMt56GA9 /eClrZaP2FCBxqFB1asz0opz/NEpBLtMWW3sFGE97sRYiMJc7QrroTXGqXqN3xok/fPV KiPKzg1OAf+uoPtdInKLygVsTkm5QPVKlcCOny/1XPHFHKQpRUupO15nHdiHd8niquGU kNZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E69YJDPLlaXVokQBDjgY9obnVVyQ0ujfRRcHSXK0Kp8=; b=EXCud7fzqbALOPcN60NPbm9XwKoU4IkaQdq9ZQaCaOkH8FgmGn4RDYRa8tg8igGLiP xa/T/nT4jZ4GrXxGJjRsKEn8fRYSmBbGNiTHrqqcbFCvbwfin2vL0brg+yt6mqg+jWeL HSnBCwaQycePCsdaL0gQ+FurNRh6TuXb1NPOMhUHcPZjrQb63vpxz+6AsIRaGGWfgw6m JjamlilwbaPuZvqUS1iMvcauycTTFBVplh7Lq458nWG4qr+n1LuwQxqu3vm1UtF6kcic lGx+Q/KiGNcwdG7eKlR2ZEaQTcputrNxGGy8E6VWxJqsVDVko7M3TkmzEVzdzvMUVsZQ +Kmw== X-Gm-Message-State: AOUpUlGTGYnrjY3Cxjfcte7EF3FirfGmvTToEeTjeokYpoFE/UCzyzAz OK8ZXEGU87SRYvcrJzM9n/5nyvbHO+I= X-Google-Smtp-Source: AAOMgpcBvuzvaUEjVckxeonPm+OlDtX4L/GCUGGGHXh3LtvASSJ/UpzUXTiFwutie3cuBKsvsRdQ0w== X-Received: by 2002:a1c:98a:: with SMTP id 132-v6mr3939889wmj.86.1532686684743; Fri, 27 Jul 2018 03:18:04 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id u18-v6sm7326904wrm.80.2018.07.27.03.18.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Jul 2018 03:18:03 -0700 (PDT) From: luca.boccassi@gmail.com To: Kiran Kumar Cc: Jerin Jacob , dpdk stable Date: Fri, 27 Jul 2018 11:17:42 +0100 Message-Id: <20180727101748.30228-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180727101748.30228-1-luca.boccassi@gmail.com> References: <20180724160752.20287-34-luca.boccassi@gmail.com> <20180727101748.30228-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/thunderx: avoid sq door bell write on zero packet' has been queued to LTS release 16.11.8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 10:18:05 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/29/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 85310ef9d404c03b932314fe91f3897401d89f24 Mon Sep 17 00:00:00 2001 From: Kiran Kumar Date: Wed, 11 Jul 2018 13:54:36 +0530 Subject: [PATCH] net/thunderx: avoid sq door bell write on zero packet [ upstream commit 47636efe878dd8885bb47b142765c9ccae6babe3 ] Avoid sq door bell write on zero packet case to reduce additional traffic on register bus. Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx") Signed-off-by: Kiran Kumar Acked-by: Jerin Jacob --- drivers/net/thunderx/nicvf_rxtx.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/net/thunderx/nicvf_rxtx.c b/drivers/net/thunderx/nicvf_rxtx.c index 275adb31c..4b9b2932c 100644 --- a/drivers/net/thunderx/nicvf_rxtx.c +++ b/drivers/net/thunderx/nicvf_rxtx.c @@ -190,12 +190,14 @@ nicvf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) free_desc -= TX_DESC_PER_PKT; } - sq->tail = tail; - sq->xmit_bufs += i; - rte_wmb(); + if (likely(i)) { + sq->tail = tail; + sq->xmit_bufs += i; + rte_wmb(); - /* Inform HW to xmit the packets */ - nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT); + /* Inform HW to xmit the packets */ + nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT); + } return i; } @@ -246,12 +248,14 @@ nicvf_xmit_pkts_multiseg(void *tx_queue, struct rte_mbuf **tx_pkts, } } - sq->tail = tail; - sq->xmit_bufs += used_bufs; - rte_wmb(); + if (likely(used_desc)) { + sq->tail = tail; + sq->xmit_bufs += used_bufs; + rte_wmb(); - /* Inform HW to xmit the packets */ - nicvf_addr_write(sq->sq_door, used_desc); + /* Inform HW to xmit the packets */ + nicvf_addr_write(sq->sq_door, used_desc); + } return i; } -- 2.18.0