From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 46A881B4E2 for ; Mon, 6 Aug 2018 12:56:37 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id h10-v6so11919424wre.6 for ; Mon, 06 Aug 2018 03:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FTrZlALC0rTFWszzXRuvdqFhoXWrP1i9uDJez36PWEg=; b=gxk+gLQA43X4PNAt9EKehhMXcVEFmbIo5BkKY2PFVhoWpT+S6ZLcbDJGX4onnWKqGb zFjRRHtXIekwlf3Ds7oLDc3a5JhVVSCwhNHtur1Y7Fdf3GASnFYP30pU6iWQqpTDQwBC IRCcQeTD/OkscNijp7tZZUf4oi7ToeVDwuAgewbhAQ8oH+hOyJlmiY/Ej33Ab+Zw7wYz vk+hq5gKE8AngRRHmX9pjxEws6N5FnUt8hyUHlmTeU3MYp4MSFV1ywcf/2oBbL3fQOAV o4OPAxD3wBmItQB/3GvSCnTwWHw3IZygXIW57utvEpGTH/P3aXWWtfGcaeAN4aRaW4A7 dFEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FTrZlALC0rTFWszzXRuvdqFhoXWrP1i9uDJez36PWEg=; b=WpkzFDPc64pUxyI900hzC9ZnZSXEj+Bwxmi68S+1Ic+4ERUqrw13O2vR45scPyT4rG yacwJMhre9Yc+cRSzKU8u92rNwE7TD8BZeE+rA+P7PrY8aaf+Vf0LCAfrzsA7c9ydTxs /RijXL6+LF42Q09G5W7zmn5IadF+yG5naoVhHJTn/tlflA495YjhDR2t+Fl5aW93JUXY RJ+9brglfhA+1IgKHq+mmtp/qNTSswmgieb1SJUH6fm8OpBcvFzJzeS5ctzeAveudsci ycHg3iF3cfjtSwLWH7lx82jLv6O2+8+2qPDojPr4YwCLRjgbTa7fhlkZQmFGZ8geGolb H8YA== X-Gm-Message-State: AOUpUlFuKkoTu692YGcw0Jni+e3BMn+IG+qCqoulSJI1l9chB16or7aI lKnxlJHLh9XmPHCM4UQiik8= X-Google-Smtp-Source: AAOMgpd9ypHBid4JzpR6EfIvSmnl6VR8BR68McB9Wa7TW9asdV24e83Ea1gLBOhndtqdpiphoxXJ1g== X-Received: by 2002:adf:84e5:: with SMTP id 92-v6mr9487718wrg.56.1533552997056; Mon, 06 Aug 2018 03:56:37 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id x62-v6sm9811498wmg.1.2018.08.06.03.56.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 03:56:36 -0700 (PDT) From: luca.boccassi@gmail.com To: Rasesh Mody Cc: dpdk stable Date: Mon, 6 Aug 2018 11:56:16 +0100 Message-Id: <20180806105619.24253-7-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180806105619.24253-1-luca.boccassi@gmail.com> References: <20180727101748.30228-1-luca.boccassi@gmail.com> <20180806105619.24253-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/bnx2x: fix FW command timeout during stop' has been queued to LTS release 16.11.8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 10:56:37 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/08/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From ad96fd0e21c84114d59c8bf673c0c5be558c63e1 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Wed, 1 Aug 2018 11:19:20 -0700 Subject: [PATCH] net/bnx2x: fix FW command timeout during stop [ upstream commit 4a4607bb9cadcc49a062a46588dbdcc873dfe27a ] This patch fixes firmware command timeout error seen during device stop while stopping queues. It patially reverts an earlier preventive change commit 91b7e432bcef ("net/bnx2x: disable fast path interrupts") to now enable fast path interrupts. The original issue of performance degradation is not observed anymore, with or without the fix. Fixes: 91b7e432bcef ("net/bnx2x: disable fast path interrupts") Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index c2842e3a25..f1de336224 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -4492,6 +4492,8 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp, int scan_fp) struct bnx2x_softc *sc = fp->sc; uint8_t more_rx = FALSE; + PMD_DRV_LOG(DEBUG, "---> FP TASK QUEUE (%d) <--", fp->index); + /* update the fastpath index */ bnx2x_update_fp_sb_idx(fp); @@ -4508,7 +4510,7 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp, int scan_fp) } bnx2x_ack_sb(sc, fp->igu_sb_id, USTORM_ID, - le16toh(fp->fp_hc_idx), IGU_INT_DISABLE, 1); + le16toh(fp->fp_hc_idx), IGU_INT_ENABLE, 1); } /* -- 2.18.0