From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 54EFB4F98 for ; Tue, 14 Aug 2018 13:07:09 +0200 (CEST) Received: from 1.general.paelzer.uk.vpn ([10.172.196.172] helo=lap.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fpXAL-0000wO-2q; Tue, 14 Aug 2018 11:07:09 +0000 From: Christian Ehrhardt To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk stable Date: Tue, 14 Aug 2018 13:06:14 +0200 Message-Id: <20180814110651.25277-11-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180814110651.25277-1-christian.ehrhardt@canonical.com> References: <20180814110651.25277-1-christian.ehrhardt@canonical.com> Subject: [dpdk-stable] patch 'net/octeontx: fix stop clearing Rx/Tx functions' has been queued to stable release 18.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 11:07:09 -0000 Hi, FYI, your patch has been queued to stable release 18.05.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/16/18. So please shout if anyone has objections. Thanks. Christian Ehrhardt --- >>From abff2c9f549bfff2896954546455e0b1e754724e Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Tue, 24 Jul 2018 16:13:50 +0530 Subject: [PATCH] net/octeontx: fix stop clearing Rx/Tx functions [ upstream commit efb9dd148e234aecd01966cd1d2aaa4b75836966 ] On dev_stop the Rx/Tx_burst functions are being set to NULL, this causes a SEGFAULT in cases where control path calls stop and a paket is still being processed by a worker. Instead clear the fastpath functions in dev_close. Fixes: da6c687471a3 ("net/octeontx: add start and stop support") Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/net/octeontx/octeontx_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index c8eb91046..f335badf8 100644 --- a/drivers/net/octeontx/octeontx_ethdev.c +++ b/drivers/net/octeontx/octeontx_ethdev.c @@ -352,6 +352,9 @@ octeontx_dev_close(struct rte_eth_dev *dev) rte_free(txq); } + + dev->tx_pkt_burst = NULL; + dev->rx_pkt_burst = NULL; } static int @@ -445,9 +448,6 @@ octeontx_dev_stop(struct rte_eth_dev *dev) ret); return; } - - dev->tx_pkt_burst = NULL; - dev->rx_pkt_burst = NULL; } static void -- 2.17.1