From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 9B9324C93 for ; Tue, 14 Aug 2018 13:14:03 +0200 (CEST) Received: from 1.general.paelzer.uk.vpn ([10.172.196.172] helo=lap.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fpXAY-0000wO-EJ; Tue, 14 Aug 2018 11:07:22 +0000 From: Christian Ehrhardt To: Ophir Munk Cc: dpdk stable Date: Tue, 14 Aug 2018 13:06:31 +0200 Message-Id: <20180814110651.25277-28-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180814110651.25277-1-christian.ehrhardt@canonical.com> References: <20180814110651.25277-1-christian.ehrhardt@canonical.com> Subject: [dpdk-stable] patch 'net/mlx5: fix secondary process resource leakage' has been queued to stable release 18.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 11:14:03 -0000 Hi, FYI, your patch has been queued to stable release 18.05.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/16/18. So please shout if anyone has objections. Thanks. Christian Ehrhardt --- >>From e5716b6ec6a3f8fe0490b7ccb8e450dda7a465ce Mon Sep 17 00:00:00 2001 From: Ophir Munk Date: Tue, 31 Jul 2018 22:38:04 +0000 Subject: [PATCH] net/mlx5: fix secondary process resource leakage [ upstream commit 09e0fd260e2e414134154b6e0e955c8424b51c0a ] When running testpmd with an mlx5 device and then executing at testpmd prompt in a raw: "port start all" followed by "port stop all" a new file named /var/tmp/net_mlx5_ is created as a result of creating a new unix domain socket (used for communication between the primary and secondary processes). When the new unix socket file is created the old unix socket file should have been removed. This commit fixes it by closing the old unix socket just before creating the new one in function mlx5_socket_init() Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor") Signed-off-by: Ophir Munk --- drivers/net/mlx5/mlx5_socket.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c index 99297d5c4..a3a522911 100644 --- a/drivers/net/mlx5/mlx5_socket.c +++ b/drivers/net/mlx5/mlx5_socket.c @@ -35,6 +35,12 @@ mlx5_socket_init(struct rte_eth_dev *dev) int ret; int flags; + /* + * Close the last socket that was used to communicate + * with the secondary process + */ + if (priv->primary_socket) + mlx5_socket_uninit(dev); /* * Initialise the socket to communicate with the secondary * process. -- 2.17.1