From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 1796E4C93 for ; Tue, 14 Aug 2018 13:12:35 +0200 (CEST) Received: from 1.general.paelzer.uk.vpn ([10.172.196.172] helo=lap.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fpXAa-0000wO-Rl; Tue, 14 Aug 2018 11:07:24 +0000 From: Christian Ehrhardt To: Wei Zhao Cc: Qi Zhang , dpdk stable Date: Tue, 14 Aug 2018 13:06:34 +0200 Message-Id: <20180814110651.25277-31-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180814110651.25277-1-christian.ehrhardt@canonical.com> References: <20180814110651.25277-1-christian.ehrhardt@canonical.com> Subject: [dpdk-stable] patch 'net/i40e: revert fix of flow director check' has been queued to stable release 18.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 11:12:35 -0000 Hi, FYI, your patch has been queued to stable release 18.05.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/16/18. So please shout if anyone has objections. Thanks. Christian Ehrhardt --- >>From e4a983a61f83018064825ab0ba7e4222a65ae02b Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Wed, 1 Aug 2018 10:54:50 +0800 Subject: [PATCH] net/i40e: revert fix of flow director check [ upstream commit 21ecd2d7ab59060e3123261d1d62a53182029dd0 ] This reverts commit 7546dc4a1331340ecb665af9af0a005bb8b657c8. In i40e FDIR PMD code for checking programming status, when the action of add FDIR filter is ok, i40e NIC will not write back to programming status descriptor, so if PMD code check DD is not done after period of time dealy, it means the add or remove filter action is ok. It only write back descriptor when fail. So, there is no issue for the original code. Fixes: 7546dc4a1331 ("net/i40e: fix check of flow director programming status") Signed-off-by: Wei Zhao Acked-by: Qi Zhang --- drivers/net/i40e/i40e_fdir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 7140237a0..a4a61d1c3 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1361,8 +1361,6 @@ i40e_check_fdir_programming_status(struct i40e_rx_queue *rxq) I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); else I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_tail - 1); - } else { - ret = -1; } return ret; -- 2.17.1